Skip to content

Conversation

@pcsosinski
Copy link

@pcsosinski pcsosinski commented Jan 14, 2021

Scheduled Cherrypicks

Known Presubmit Failures

  • LUCI customer_testing depends on a script in the recipes repo that clones customer_testing from HEAD

Known Postsubmit Failures

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard bot added engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 14, 2021
@google-cla
Copy link

google-cla bot commented Jan 14, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jan 14, 2021
@jmagman
Copy link
Member

jmagman commented Jan 14, 2021

 'Xcode' is from 'package:flutter_tools/src/macos/xcode.dart' ('packages/flutter_tools/lib/src/macos/xcode.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'majorVersion'.
    if (boolArg('xcframework') && globals.xcode.majorVersion < 11) {

Patch:
xcode-11.diff.txt

Removes lines:
https://github.com/flutter/flutter/blob/beta/packages/flutter_tools/lib/src/commands/build_ios_framework.dart#L156-L158

This check for a minimum of Xcode 11 is unnecessary--Xcode 11 has been the minimum required version for awhile.

@google-cla
Copy link

google-cla bot commented Jan 14, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@christopherfujino
Copy link
Contributor

manually set label cla: yes because all commit authors have already signed the CLA.

@skia-gold
Copy link

Gold has detected about 14 untriaged digest(s) on patchset 5.
View them at https://flutter-gold.skia.org/cl/github/73985

@christopherfujino christopherfujino self-requested a review January 14, 2021 23:55
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcsosinski
Copy link
Author

customer testing failing as expected / 33 failures related to pre-submit recipe changes at master that we expect to pass on post-submit (branched recipes)

@pcsosinski pcsosinski merged commit 5d36f2e into flutter:flutter-1.25-candidate.8 Jan 14, 2021
@pcsosinski pcsosinski deleted the flutter-1.25-candidate.8 branch January 15, 2021 00:59
@christopherfujino
Copy link
Contributor

ios_app_with_extensions_test failed post-submit with an infra failure that was fixed upstream with: https://github.com/flutter/flutter/pull/73442/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants