-
Notifications
You must be signed in to change notification settings - Fork 29.8k
[flutter_releases] Flutter 1.25.0-8.3.pre framework cherrypicks #73985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_releases] Flutter 1.25.0-8.3.pre framework cherrypicks #73985
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Patch: Removes lines: This check for a minimum of Xcode 11 is unnecessary--Xcode 11 has been the minimum required version for awhile. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
manually set label |
|
Gold has detected about 14 untriaged digest(s) on patchset 5. |
christopherfujino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
customer testing failing as expected / 33 failures related to pre-submit recipe changes at master that we expect to pass on post-submit (branched recipes) |
|
|
Scheduled Cherrypicks
update engine
[CupertinoDatePicker] Selection background is broken for mode "time" and "dateAndTime" · Issue [CupertinoDatePicker] Selection background is broken for mode "time" and "dateAndTime" #73203
Cupertino Icons draws the wrong icon that you selected in the code · Issue Cupertino Icons draws the wrong icon that you selected in the code #72237
Add minimum recommended version of Xcode to doctor · Issue Add minimum recommended version of Xcode to doctor #73801
Known Presubmit Failures
customer_testingdepends on a script in the recipes repo that clones customer_testing from HEADKnown Postsubmit Failures
ios_app_with_extensions_testfailed with an infra failure that was fixed upstream with: https://github.com/flutter/flutter/pull/73442/files