Make LayoutCallback generic and other minor changes #7367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LayoutCallback passes constraints to the callback, but the constraints object has a different type for different subclasses. This lets you call invokeLayoutCallback() with a specific type to verify that everything is working as expected. Other changes: Slightly improve the error reporting in RenderObject. Allow toStringShallow on RenderObject to have its separator configured.
abarth
reviewed
Jan 6, 2017
|
|
||
| if (callback != null) | ||
| invokeLayoutCallback(callback); | ||
| invokeLayoutCallback/*<BoxConstraints>*/(callback); |
Contributor
There was a problem hiding this comment.
I thought we could use real generic functions now. I know you haven't landed the uber conversions patch, but maybe we should start using the real syntax for new instances?
Contributor
Author
There was a problem hiding this comment.
Needs a dart roll still.
Contributor
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LayoutCallback passes constraints to the callback, but the constraints
object has a different type for different subclasses. This lets you
call invokeLayoutCallback() with a specific type to verify that
everything is working as expected.
Other changes:
Slightly improve the error reporting in RenderObject.
Allow toStringShallow on RenderObject to have its separator configured.