Remove manual Flutter linking for iOS projects #71862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Dec 7, 2020
Member
gaaclarke
left a comment
There was a problem hiding this comment.
LGTM, here's a further description of autolink: https://stackoverflow.com/questions/42646716/how-is-a-blank-new-cocoa-app-project-linking-with-the-system-frameworks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flutter projects don't actually need to tell the linker about the
Flutterframework becauseCLANG_MODULES_AUTOLINKdefaults toYES(inherited from the OS default), which means justimporting theFluttermodule will link it.This is why
OTHER_LDFLAGSdoesn't need to contain-framework Foundationor any other frameworks that are auto-imported.Will also prevent add-to-app warning
flutter_export_environment.sh: line 8: inherited: command not found, which is innocuous, but causes confusion.Related Issues
Fixes #54769
Tests
Remove
OTHER_LDFLAGStests.Confirmed this worked in both an existing Objective-C and Swift project.