Skip to content

Expose the YearPicker as a public API again to match the previous API.#71061

Merged
darrenaustin merged 1 commit intoflutter:masterfrom
darrenaustin:year_picker
Nov 23, 2020
Merged

Expose the YearPicker as a public API again to match the previous API.#71061
darrenaustin merged 1 commit intoflutter:masterfrom
darrenaustin:year_picker

Conversation

@darrenaustin
Copy link
Contributor

@darrenaustin darrenaustin commented Nov 23, 2020

Description

When we updated the design of the Date PIcker to match the latest Material Design spec, we deprecated the existing YearPicker API as it was not seen as very useful on its own and the visuals changed. However, we have had some feedback from the community that this was still a useful widget, so this PR exposes the new YearPicker implementation as a supported widget matching the old API.

YearPicker

Related Issues

Fixes: #39961

Tests

I added several tests for this widget to the calendar_date_picker.dart tests (as the YearPicker lives in the calendar_date_picker.dart file).

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them?

  • No, no existing tests failed, so this is not a breaking change.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Nov 23, 2020
@google-cla google-cla bot added the cla: yes label Nov 23, 2020
Copy link
Contributor

@rami-a rami-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Year picker support

3 participants