Expose the YearPicker as a public API again to match the previous API.#71061
Merged
darrenaustin merged 1 commit intoflutter:masterfrom Nov 23, 2020
darrenaustin:year_picker
Merged
Expose the YearPicker as a public API again to match the previous API.#71061darrenaustin merged 1 commit intoflutter:masterfrom darrenaustin:year_picker
darrenaustin merged 1 commit intoflutter:masterfrom
darrenaustin:year_picker
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When we updated the design of the Date PIcker to match the latest Material Design spec, we deprecated the existing
YearPickerAPI as it was not seen as very useful on its own and the visuals changed. However, we have had some feedback from the community that this was still a useful widget, so this PR exposes the newYearPickerimplementation as a supported widget matching the old API.Related Issues
Fixes: #39961
Tests
I added several tests for this widget to the calendar_date_picker.dart tests (as the YearPicker lives in the calendar_date_picker.dart file).
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them?