Skip to content

Remove unnecessary argument from Row and Column constructor comments#71041

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
chulwoo-park:master
Nov 22, 2020
Merged

Remove unnecessary argument from Row and Column constructor comments#71041
fluttergithubbot merged 1 commit intoflutter:masterfrom
chulwoo-park:master

Conversation

@chulwoo-park
Copy link
Contributor

@chulwoo-park chulwoo-park commented Nov 22, 2020

Description

It doesn't seem to be removed when copy&paste from Flex comments.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Nov 22, 2020
@google-cla google-cla bot added the cla: yes label Nov 22, 2020
@Hixie
Copy link
Contributor

Hixie commented Nov 22, 2020

Thanks!

Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants