[flutter_tools] fix port leak in flutter_driver#70999
Merged
jonahwilliams merged 1 commit intoflutter:masterfrom Nov 21, 2020
Merged
[flutter_tools] fix port leak in flutter_driver#70999jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams merged 1 commit intoflutter:masterfrom
Conversation
dnfield
approved these changes
Nov 21, 2020
Contributor
dnfield
left a comment
There was a problem hiding this comment.
LGTM
I wonder if this was causing some of the hangs we were seeing.
Contributor
Author
|
Probably, though I think the other problems were caused by running through pub |
|
Will this be cherry-picked to 1.24? |
Contributor
Author
|
1.24 is not released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The connect URI method in flutter driver was leaking a port. Fix this so that the tool does not need to run through pub.
Fixes #70983