Remove private OutlinedButton default outline geometry class#70975
Merged
HansMuller merged 1 commit intoflutter:masterfrom Nov 23, 2020
Merged
Conversation
Contributor
Author
|
The problems reported by "Google Testing" were fixed in (internal Google change) cl/343891652. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove OutlinedButton's private
_OutlineRoundedRectangleBorder subclass.It was added in #70393 to satisfy a backwards incompatibility (a one pixel difference) in the way the default outline was rendered. This is no longer necessary as of (internal Google change) cl/339303032.