Skip to content

[devicelab] don't use set modified for hot reload bench#70965

Merged
dnfield merged 1 commit intoflutter:masterfrom
jonahwilliams:fix_hot_reload_bench_2131231
Nov 20, 2020
Merged

[devicelab] don't use set modified for hot reload bench#70965
dnfield merged 1 commit intoflutter:masterfrom
jonahwilliams:fix_hot_reload_bench_2131231

Conversation

@jonahwilliams
Copy link
Contributor

Description

Turns out it is flaky

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Nov 20, 2020
@google-cla google-cla bot added the cla: yes label Nov 20, 2020
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield
Copy link
Contributor

dnfield commented Nov 20, 2020

Landing on red to help with greeness of tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants