flutter_tools: do more refactor on CreateBase and CreateCommand#70959
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Nov 20, 2020
Merged
flutter_tools: do more refactor on CreateBase and CreateCommand#70959fluttergithubbot merged 1 commit intoflutter:masterfrom
CreateBase and CreateCommand#70959fluttergithubbot merged 1 commit intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
cyanglaz
commented
Nov 20, 2020
| /// If `--org` is not specified, returns the organization from the existing project. | ||
| @protected | ||
| Future<String> getOrganization(Directory projectDir) async { | ||
| Future<String> getOrganization() async { |
Contributor
Author
There was a problem hiding this comment.
@jmagman Since this method returns a future and it's not a constant lookup, I decided not making this a getter based on
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#getters-feel-faster-than-methods
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes additional refactoring to #70874
projectDirandprojectDirPatha getter in theCreateBasegetFlutterRoot(),getProjectName ()getters.validateProjectDir()Related Issues
#59494
Tests
I added the following tests:
This is a pure refactoring, nothing new was added.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.