Skip to content

[flutter_tools] disable SWR optimization on dev#70912

Merged
jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams:disable_swr_on_dev
Nov 21, 2020
Merged

[flutter_tools] disable SWR optimization on dev#70912
jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams:disable_swr_on_dev

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Nov 20, 2020

Description

The oct-nov period where this feature was enabled show a large variance in hot reload times compared to prior months, and not an average improvement. its possible this is related to null safety work, but to be sure - disable this feature so that we can gather stats for december/jan

@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 20, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 20, 2020
@google-cla google-cla bot added the cla: yes label Nov 20, 2020
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Nov 20, 2020

Possible outcomes:

  • if performance starts to improve on dev after a release where this was landed, then back to the drawing board
  • If performance gets worse or stays the same, well then it is probably null safety related and we should proceed with moving this forward

@jonahwilliams jonahwilliams requested review from christopherfujino, jmagman and zanderso and removed request for zanderso November 20, 2020 18:11
jmagman
jmagman approved these changes Nov 21, 2020
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit 9746619 into flutter:master Nov 21, 2020
@jonahwilliams jonahwilliams deleted the disable_swr_on_dev branch November 21, 2020 00:27
@oshtman oshtman mentioned this pull request May 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams @jmagman