Skip to content

Conversation

@goderbauer
Copy link
Member

Description

With a fix to RenderFlex we can remove intrinsics from one of the SliverFillRemainings.

Fix to RenderFlex: If a min extent is given, it should flex its children to at least fill the min extent even when the max extent is unbound. After all, it was asked to provide content for at least the min extent.

The RenderSliverFillRemainingAndOverscroll is still using intrinsics because it needs to know how much space the child would occupy if it doesn't reach into the overscroll. For that, we need to know the intrinsics of the child.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Nov 19, 2020
@google-cla google-cla bot added the cla: yes label Nov 19, 2020
@goderbauer goderbauer requested review from Hixie and Piinks and removed request for Hixie November 19, 2020 18:44
@Piinks Piinks added the f: scrolling Viewports, list views, slivers, etc. label Nov 19, 2020
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RenderSliverFillRemainingAndOverscroll is still using intrinsics because it needs to know how much space the child would occupy if it doesn't reach into the overscroll. For that, we need to know the intrinsics of the child.

Can you add a comment to this class that adds more clarity to why we use intrinsics there? :)

@goderbauer
Copy link
Member Author

Can you add a comment to this class that adds more clarity to why we use intrinsics there? :)

Done.

@Hixie
Copy link
Contributor

Hixie commented Nov 19, 2020

LGTM. I'm curious if this breaks anything in google3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants