Material Date Picker code restructure#70708
Merged
darrenaustin merged 8 commits intoflutter:masterfrom Nov 20, 2020
darrenaustin:date_picker_structure
Merged
Material Date Picker code restructure#70708darrenaustin merged 8 commits intoflutter:masterfrom darrenaustin:date_picker_structure
darrenaustin merged 8 commits intoflutter:masterfrom
darrenaustin:date_picker_structure
Conversation
rami-a
approved these changes
Nov 17, 2020
packages/flutter/lib/src/material/input_date_picker_form_field.dart
Outdated
Show resolved
Hide resolved
…veral of the non-public implementation files into date_picker.dart.
…s with the implementation.
…he calendar and input date picker tests.
…ed into date_picker.dart
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In order to better match the rest of the framework code base, this PR restructures the implementation of the Material Date Picker. The current code structure for the date pickers is:
I would like to combine several of these and move everything up to the top level
materialdirectory as follows:showDatePicker/RangePicker, date_picker_header and dialogsIn addition, we should add new test files for the top level components:
This should bring the code structure for the Date Pickers to be more inline with the rest of the flutter framework, and thus easier for people to follow. This will also remove un-exported public symbols that were still technically available for people to use.
Related Issues
Fixes: #69939
Tests
I added the following tests:
test/material/calendar_date_picker_test
test/material/input_date_picker_form_field_test.dart
And moved others around.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them?