Skip to content

Conversation

@jiahaog
Copy link
Member

@jiahaog jiahaog commented Nov 14, 2020

Description

Reland #70075

See 2a3256e for the changes made against the previous PR. These changes should already be present on HEAD in binding_fail_test.dart, but somehow Git isn't able to detect that the file has moved.

Also ran ..\..\bin\flutter test (from the integration_test package on my windows machine which passes

Related Issues

Fixes #50816
Fixes #70467

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Nov 14, 2020
@google-cla google-cla bot added the cla: yes label Nov 14, 2020
@jiahaog jiahaog marked this pull request as ready for review November 14, 2020 01:42
@jiahaog jiahaog force-pushed the reland-integration-reporter branch from d2d1bf2 to 2a3256e Compare November 14, 2020 01:47
@jiahaog jiahaog requested a review from dnfield November 14, 2020 03:02
@jiahaog jiahaog changed the title [integration_test] Reland Add a run method for proper reporting of test results [integration_test] Reland add a run method for proper reporting of test results Nov 14, 2020
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield dnfield merged commit 87746c7 into flutter:master Nov 14, 2020
@jiahaog jiahaog deleted the reland-integration-reporter branch November 14, 2020 03:59
@dnfield dnfield mentioned this pull request Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

2 participants