Revert "[integration_test] Add a `run` method for proper reporting of test results" #70466

jonahwilliams · 2020-11-13T17:00:56Z

This is failing on the windows shard: https://ci.chromium.org/p/flutter/builders/prod/Windows%20framework_tests/1055

specifically:

00:12 +0: C:\b\s\w\ir\k\flutter\packages\integration_test\test\binding_test.dart: Test Integration binding Run Integration app                                                                         Shell: CreateProcessW failed 2

00:12 +0 -1: C:\b\s\w\ir\k\flutter\packages\integration_test\test\reporter\legacy_reporter_test.dart: When multiple tests pass [E]                                                                     
  ProcessException: The system cannot find the file specified.
  
    Command: flutter test --machine test/reporter/data/pass_test_script.dart
  dart:io                                   Process.start
  reporter\legacy_reporter_test.dart 48:41  _runTest
  reporter\legacy_reporter_test.dart 20:48  main.<fn>
  reporter\legacy_reporter_test.dart 19:36  main.<fn>
  
Shell: CreateProcessW failed 2

00:12 +0 -2: C:\b\s\w\ir\k\flutter\packages\integration_test\test\reporter\legacy_reporter_test.dart: When multiple tests fail [E]                                                                     
  ProcessException: The system cannot find the file specified.
  
    Command: flutter test --machine test/reporter/data/fail_test_script.dart
  dart:io                                   Process.start
  reporter\legacy_reporter_test.dart 48:41  _runTest
  reporter\legacy_reporter_test.dart 28:48  main.<fn>
  reporter\legacy_reporter_test.dart 27:36  main.<fn>
  
Shell: CreateProcessW failed 2

00:12 +0 -3: C:\b\s\w\ir\k\flutter\packages\integration_test\test\reporter\legacy_reporter_test.dart: When one test passes, then another fails [E]                                                     
  ProcessException: The system cannot find the file specified.
  
    Command: flutter test --machine test/reporter/data/pass_then_fail_test_script.dart
  dart:io                                   Process.start
  reporter\legacy_reporter_test.dart 48:41  _runTest
  reporter\legacy_reporter_test.dart 36:48  main.<fn>
  reporter\legacy_reporter_test.dart 35:52  main.<fn>
  

00:12 +0 -3: C:\b\s\w\ir\k\flutter\packages\integration_test\test\binding_test.dart: Test Integration binding Run Integration app                                                                      
00:12 +1 -3: C:\b\s\w\ir\k\flutter\packages\integration_test\test\reporter\multiple_tests_fail_test.dart: When multiple tests fail                                                                     
00:12 +1 -3: C:\b\s\w\ir\k\flutter\packages\integration_test\test\reporter\multiple_tests_fail_test.dart: When multiple tests fail                                                                     
Using the legacy test result reporter, which will not catch all errors thrown in declared tests. Consider wrapping tests with https://api.flutter.dev/flutter/integration_test/run.html instead.

00:12 +2 -3: C:\b\s\w\ir\k\flutter\packages\integration_test\test\reporter\multiple_tests_fail_test.dart: When multiple tests fail                                                                     
00:12 +3 -3: C:\b\s\w\ir\k\flutter\packages\integration_test\test\reporter\multiple_tests_fail_test.dart: When multiple tests fail                                                                     
00:12 +4 -3: C:\b\s\w\ir\k\flutter\packages\integration_test\test\reporter\multiple_tests_fail_test.dart: When multiple tests fail                                                                     
00:12 +4 -3: C:\b\s\w\ir\k\flutter\packages\integration_test\test\binding_test.dart: Test Integration binding (tearDownAll)                                                                            
Test execution completed: {Run Integration app: Instance of 'Success', setSurfaceSize works: Instance of 'Success', Test traceAction: Instance of 'Success'}
Warning: integration_test test plugin was not detected.

00:12 +4 -3: C:\b\s\w\ir\k\flutter\packages\integration_test\test\reporter\multiple_tests_fail_test.dart: When multiple tests fail                                                                     Shell: (The following exception is now available via WidgetTester.takeException:)
Shell: ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
Shell: The following TestFailure object was thrown running a test:
Shell:   Expected: <true>
Shell:   Actual: <false>
Shell: 
Shell: When the exception was thrown, this was the stack:
Shell: #4      _testMain.<anonymous closure> (file:///C:/b/s/w/ir/k/flutter/packages/integration_test/test/reporter/multiple_tests_fail_test.dart:23:5)
Shell: #5      _testMain.<anonymous closure> (file:///C:/b/s/w/ir/k/flutter/packages/integration_test/test/reporter/multiple_tests_fail_test.dart:22:40)
Shell: #6      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:144:29)
Shell: <asynchronous suspension>
Shell: <asynchronous suspension>
Shell: (elided one frame from package:stack_trace)
Shell: 
Shell: This was caught by the test expectation on the following line:
Shell:   file:///C:/b/s/w/ir/k/flutter/packages/integration_test/test/reporter/multiple_tests_fail_test.dart line 23
Shell: The test description was:
Shell:   Failing testWidgets()
Shell: ════════════════════════════════════════════════════════════════════════════════════════════════════
Shell: (If WidgetTester.takeException is called, the above exception will be ignored. If it is not, then the above exception will be dumped when another exception is caught by the framework or when the test ends, whichever happens first, and then the test will fail due to having not caught or expected the exception.)

00:12 +4 -3: C:\b\s\w\ir\k\flutter\packages\integration_test\test\reporter\multiple_tests_fail_test.dart: When multiple tests fail                                                                     
Test execution completed: {Failing testWidgets(): {"methodName":"Failing testWidgets()","error":"Test Failing testWidgets() failed: ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞═════════════════\nThe following TestFailure object was thrown running a test:\n  Expected: <true>\n  Actual: <false>\n\nWhen the exception was thrown, this was the stack:\n#4      _testMain.<anonymous closure> (file:///C:/b/s/w/ir/k/flutter/packages/integration_test/test/reporter/multiple_tests_fail_test.dart:23:5)\n#5      _testMain.<anonymous closure> (file:///C:/b/s/w/ir/k/flutter/packages/integration_test/test/reporter/multiple_tests_fail_test.dart:22:40)\n#6      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:144:29)\n<asynchronous suspension>\n<asynchronous suspension>\n(elided one frame from package:stack_trace)\n\nThis was caught by the test expectation on the following line:\n  file:///C:/b/s/w/ir/k/flutter/packages/integration_test/test/reporter/multiple_tests_fail_test.dart line 23\nThe test description was:\n  Failing testWidgets()\n═════════════════════════════════════════════════════════════════\n","details":"===== asynchronous gap ===========================\ndart:async/zone.dart 1126:19                                   _CustomZone.registerBinaryCallback\ndart:async-patch/async_patch.dart 51:8                         _asyncErrorWrapperHelper\ndart:async/zone.dart 1218:13                                   _rootRunBinary\ndart:async/zone.dart 1104:19                                   _CustomZone.runBinary\npackage:flutter_test/src/binding.dart 777:14                   TestWidgetsFlutterBinding._runTest\npackage:flutter_test/src/binding.dart 1631:12                  LiveTestWidgetsFlutterBinding.runTest\npackage:integration_test/integration_test.dart 272:17          IntegrationTestWidgetsFlutterBinding.runTest\npackage:flutter_test/src/widget_tester.dart 136:24             testWidgets.<fn>\npackage:test_api/src/backend/declarer.dart 200:19              Declarer.test.<fn>.<fn>\n===== asynchronous gap ===========================\ndart:async/zone.dart 1118:19                                   _CustomZone.registerUnaryCallback\ndart:async-patch/async_patch.dart 40:23                        _asyncThenWrapperHelper\npackage:test_api/src/backend/declarer.dart                     Declarer.test.<fn>.<fn>\ndart:async/zone.dart 1186:13                                   _rootRun\ndart:async/zone.dart 1090:19                                   _CustomZone.run\ndart:async/zone.dart 1626:10                                   _runZoned\ndart:async/zone.dart 1546:10                                   runZoned\npackage:test_api/src/backend/declarer.dart 198:13              Declarer.test.<fn>\npackage:test_api/src/backend/declarer.dart 181:48              Declarer.test.<fn>\npackage:test_api/src/backend/invoker.dart 231:15               Invoker.waitForOutstandingCallbacks.<fn>\npackage:test_api/src/backend/invoker.dart 228:14               Invoker.waitForOutstandingCallbacks.<fn>\ndart:async/zone.dart 1186:13                                   _rootRun\ndart:async/zone.dart 1090:19                                   _CustomZone.run\ndart:async/zone.dart 1626:10                                   _runZoned\ndart:async/zone.dart 1546:10                                   runZoned\npackage:test_api/src/backend/invoker.dart 228:5                Invoker.waitForOutstandingCallbacks\npackage:test_api/src/backend/invoker.dart 383:17               Invoker._onRun.<fn>.<fn>.<fn>\n===== asynchronous gap ===========================\ndart:async/zone.dart 1118:19                                   _CustomZone.registerUnaryCallback\ndart:async-patch/async_patch.dart 40:23                        _asyncThenWrapperHelper\npackage:test_api/src/backend/invoker.dart                      Invoker._onRun.<fn>.<fn>.<fn>\ndart:async/zone.dart 1186:13                                   _rootRun\ndart:async/zone.dart 1090:19                                   _CustomZone.run\ndart:async/zone.dart 1626:10                                   _runZoned\ndart:async/zone.dart 1546:10                                   runZoned\npackage:test_api/src/backend/invoker.dart 370:9                Invoker._onRun.<fn>.<fn>\npackage:test_api/src/backend/invoker.dart 415:15               Invoker._guardIfGuarded\npackage:test_api/src/backend/invoker.dart 369:7                Invoker._onRun.<fn>\npackage:stack_trace/src/chain.dart 94:24                       Chain.capture.<fn>\ndart:async/zone.dart 1186:13                                   _rootRun\ndart:async/zone.dart 1090:19                                   _CustomZone.run\ndart:async/zone.dart 1626:10                                   _runZoned\ndart:async/zone.dart 1546:10                                   runZoned\npackage:stack_trace/src/chain.dart 92:12                       Chain.capture\npackage:test_api/src/backend/invoker.dart 368:11               Invoker._onRun\npackage:test_api/src/backend/live_test_controller.dart 153:11  LiveTestController.run\ndart:async/future.dart 201:37                                  new Future.microtask.<fn>\npackage:stack_trace/src/stack_zone_specification.dart 208:15   StackZoneSpecification._run\npackage:stack_trace/src/stack_zone_specification.dart 116:48   StackZoneSpecification._registerCallback.<fn>\ndart:async/zone.dart 1178:47                                   _rootRun\ndart:async/zone.dart 1090:19                                   _CustomZone.run\ndart:async/zone.dart 994:7                                     _CustomZone.runGuarded\ndart:async/zone.dart 1034:23                                   _CustomZone.bindCallbackGuarded.<fn>\npackage:stack_trace/src/stack_zone_specification.dart 208:15   StackZoneSpecification._run\npackage:stack_trace/src/stack_zone_specification.dart 116:48   StackZoneSpecification._registerCallback.<fn>\ndart:async/zone.dart 1186:13                                   _rootRun\ndart:async/zone.dart 1090:19                                   _CustomZone.run\ndart:async/zone.dart 994:7                                     _CustomZone.runGuarded\ndart:async/zone.dart 1034:23                                   _CustomZone.bindCallbackGuarded.<fn>\ndart:async/schedule_microtask.dart 41:21                       _microtaskLoop\ndart:async/schedule_microtask.dart 50:5                        _startMicrotaskLoop\n"}, Failing test(): {"methodName":"Failing test()","error":"Expected: <true>\n  Actual: <false>\n","details":"package:test_api/src/frontend/expect.dart 155:31               fail\npackage:test_api/src/frontend/expect.dart 150:3                _expect\npackage:test_api/src/frontend/expect.dart 59:3                 expect\npackage:flutter_test/src/widget_tester.dart 429:3              expect\nreporter\\multiple_tests_fail_test.dart 27:5                    _testMain.<fn>\npackage:test_api/src/backend/declarer.dart 200:19              Declarer.test.<fn>.<fn>\n===== asynchronous gap ===========================\ndart:async/zone.dart 1126:19                                   _CustomZone.registerBinaryCallback\ndart:async-patch/async_patch.dart 51:8                         _asyncErrorWrapperHelper\npackage:test_api/src/backend/invoker.dart                      Invoker.waitForOutstandingCallbacks.<fn>\ndart:async/zone.dart 1186:13                                   _rootRun\ndart:async/zone.dart 1090:19                                   _CustomZone.run\ndart:async/zone.dart 1626:10                                   _runZoned\ndart:async/zone.dart 1546:10                                   runZoned\npackage:test_api/src/backend/invoker.dart 228:5                Invoker.waitForOutstandingCallbacks\npackage:test_api/src/backend/invoker.dart 383:17               Invoker._onRun.<fn>.<fn>.<fn>\n===== asynchronous gap ===========================\ndart:async/zone.dart 1118:19                                   _CustomZone.registerUnaryCallback\ndart:async-patch/async_patch.dart 40:23                        _asyncThenWrapperHelper\npackage:test_api/src/backend/invoker.dart                      Invoker._onRun.<fn>.<fn>.<fn>\ndart:async/zone.dart 1186:13                                   _rootRun\ndart:async/zone.dart 1090:19                                   _CustomZone.run\ndart:async/zone.dart 1626:10                                   _runZoned\ndart:async/zone.dart 1546:10                                   runZoned\npackage:test_api/src/backend/invoker.dart 370:9                Invoker._onRun.<fn>.<fn>\npackage:test_api/src/backend/invoker.dart 415:15               Invoker._guardIfGuarded\npackage:test_api/src/backend/invoker.dart 369:7                Invoker._onRun.<fn>\npackage:stack_trace/src/chain.dart 94:24                       Chain.capture.<fn>\ndart:async/zone.dart 1186:13                                   _rootRun\ndart:async/zone.dart 1090:19                                   _CustomZone.run\ndart:async/zone.dart 1626:10                                   _runZoned\ndart:async/zone.dart 1546:10                                   runZoned\npackage:stack_trace/src/chain.dart 92:12                       Chain.capture\npackage:test_api/src/backend/invoker.dart 368:11               Invoker._onRun\npackage:test_api/src/backend/live_test_controller.dart 153:11  LiveTestController.run\ndart:async/future.dart 201:37                                  new Future.microtask.<fn>\npackage:stack_trace/src/stack_zone_specification.dart 208:15   StackZoneSpecification._run\npackage:stack_trace/src/stack_zone_specification.dart 116:48   StackZoneSpecification._registerCallback.<fn>\ndart:async/zone.dart 1178:47                                   _rootRun\ndart:async/zone.dart 1090:19                                   _CustomZone.run\ndart:async/zone.dart 994:7                                     _CustomZone.runGuarded\ndart:async/zone.dart 1034:23                                   _CustomZone.bindCallbackGuarded.<fn>\npackage:stack_trace/src/stack_zone_specification.dart 208:15   StackZoneSpecification._run\npackage:stack_trace/src/stack_zone_specification.dart 116:48   StackZoneSpecification._registerCallback.<fn>\ndart:async/zone.dart 1186:13                                   _rootRun\ndart:async/zone.dart 1090:19                                   _CustomZone.run\ndart:async/zone.dart 994:7                                     _CustomZone.runGuarded\ndart:async/zone.dart 1034:23                                   _CustomZone.bindCallbackGuarded.<fn>\ndart:async/schedule_microtask.dart 41:21                       _microtaskLoop\ndart:async/schedule_microtask.dart 50:5                        _startMicrotaskLoop\n"}}

00:12 +5 -3: C:\b\s\w\ir\k\flutter\packages\integration_test\test\reporter\multiple_tests_pass_test.dart: When multiple tests pass                                                                     
00:12 +5 -3: C:\b\s\w\ir\k\flutter\packages\integration_test\test\reporter\multiple_tests_pass_test.dart: When multiple tests pass                                                                     
Using the legacy test result reporter, which will not catch all errors thrown in declared tests. Consider wrapping tests with https://api.flutter.dev/flutter/integration_test/run.html instead.

00:13 +5 -3: C:\b\s\w\ir\k\flutter\packages\integration_test\test\reporter\pass_then_fail_test.dart: when one test passes, then another fails                                                          
Using the legacy test result reporter, which will not catch all errors thrown in declared tests. Consider wrapping tests with https://api.flutter.dev/flutter/integration_test/run.html instead.

00:13 +5 -3: C:\b\s\w\ir\k\flutter\packages\integration_test\test\reporter\multiple_tests_pass_test.dart: When multiple tests pass                                                                     
Test execution completed: {Passing testWidgets(): Instance of 'Success', Passing test(): Instance of 'Success'}

00:13 +6 -3: C:\b\s\w\ir\k\flutter\packages\integration_test\test\reporter\pass_then_fail_test.dart: when one test passes, then another fails                                                          
00:13 +7 -3: C:\b\s\w\ir\k\flutter\packages\integration_test\test\reporter\pass_then_fail_test.dart: when one test passes, then another fails                                                          
00:13 +8 -3: C:\b\s\w\ir\k\flutter\packages\integration_test\test\reporter\pass_then_fail_test.dart: when one test passes, then another fails                                                          Shell: (The following exception is now available via WidgetTester.takeException:)
Shell: ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
Shell: The following TestFailure object was thrown running a test:
Shell:   Expected: <true>
Shell:   Actual: <false>
Shell: 
Shell: When the exception was thrown, this was the stack:
Shell: #4      _testMain.<anonymous closure> (file:///C:/b/s/w/ir/k/flutter/packages/integration_test/test/reporter/pass_then_fail_test.dart:27:5)
Shell: #5      _testMain.<anonymous closure> (file:///C:/b/s/w/ir/k/flutter/packages/integration_test/test/reporter/pass_then_fail_test.dart:26:31)
Shell: #6      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:144:29)
Shell: <asynchronous suspension>
Shell: <asynchronous suspension>
Shell: (elided one frame from package:stack_trace)
Shell: 
Shell: This was caught by the test expectation on the following line:
Shell:   file:///C:/b/s/w/ir/k/flutter/packages/integration_test/test/reporter/pass_then_fail_test.dart line 27
Shell: The test description was:
Shell:   Failing test
Shell: ════════════════════════════════════════════════════════════════════════════════════════════════════
Shell: (If WidgetTester.takeException is called, the above exception will be ignored. If it is not, then the above exception will be dumped when another exception is caught by the framework or when the test ends, whichever happens first, and then the test will fail due to having not caught or expected the exception.)

00:13 +8 -3: C:\b\s\w\ir\k\flutter\packages\integration_test\test\reporter\pass_then_fail_test.dart: when one test passes, then another fails                                                          
Test execution completed: {Passing test: Instance of 'Success', Failing test: {"methodName":"Failing test","error":"Test Failing test failed: ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞═════════════════\nThe following TestFailure object was thrown running a test:\n  Expected: <true>\n  Actual: <false>\n\nWhen the exception was thrown, this was the stack:\n#4      _testMain.<anonymous closure> (file:///C:/b/s/w/ir/k/flutter/packages/integration_test/test/reporter/pass_then_fail_test.dart:27:5)\n#5      _testMain.<anonymous closure> (file:///C:/b/s/w/ir/k/flutter/packages/integration_test/test/reporter/pass_then_fail_test.dart:26:31)\n#6      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:144:29)\n<asynchronous suspension>\n<asynchronous suspension>\n(elided one frame from package:stack_trace)\n\nThis was caught by the test expectation on the following line:\n  file:///C:/b/s/w/ir/k/flutter/packages/integration_test/test/reporter/pass_then_fail_test.dart line 27\nThe test description was:\n  Failing test\n═════════════════════════════════════════════════════════════════\n","details":"===== asynchronous gap ===========================\ndart:async/zone.dart 1126:19                                   _CustomZone.registerBinaryCallback\ndart:async-patch/async_patch.dart 51:8                         _asyncErrorWrapperHelper\ndart:async/zone.dart 1218:13                                   _rootRunBinary\ndart:async/zone.dart 1104:19                                   _CustomZone.runBinary\npackage:flutter_test/src/binding.dart 777:14                   TestWidgetsFlutterBinding._runTest\npackage:flutter_test/src/binding.dart 1631:12                  LiveTestWidgetsFlutterBinding.runTest\npackage:integration_test/integration_test.dart 272:17          IntegrationTestWidgetsFlutterBinding.runTest\npackage:flutter_test/src/widget_tester.dart 136:24             testWidgets.<fn>\npackage:test_api/src/backend/declarer.dart 200:19              Declarer.test.<fn>.<fn>\n===== asynchronous gap ===========================\ndart:async/zone.dart 1118:19                                   _CustomZone.registerUnaryCallback\ndart:async-patch/async_patch.dart 40:23                        _asyncThenWrapperHelper\npackage:test_api/src/backend/declarer.dart                     Declarer.test.<fn>.<fn>\ndart:async/zone.dart 1186:13                                   _rootRun\ndart:async/zone.dart 1090:19                                   _CustomZone.run\ndart:async/zone.dart 1626:10                                   _runZoned\ndart:async/zone.dart 1546:10                                   runZoned\npackage:test_api/src/backend/declarer.dart 198:13              Declarer.test.<fn>\npackage:test_api/src/backend/declarer.dart 181:48              Declarer.test.<fn>\npackage:test_api/src/backend/invoker.dart 231:15               Invoker.waitForOutstandingCallbacks.<fn>\npackage:test_api/src/backend/invoker.dart 228:14               Invoker.waitForOutstandingCallbacks.<fn>\ndart:async/zone.dart 1186:13                                   _rootRun\ndart:async/zone.dart 1090:19                                   _CustomZone.run\ndart:async/zone.dart 1626:10                                   _runZoned\ndart:async/zone.dart 1546:10                                   runZoned\npackage:test_api/src/backend/invoker.dart 228:5                Invoker.waitForOutstandingCallbacks\npackage:test_api/src/backend/invoker.dart 383:17               Invoker._onRun.<fn>.<fn>.<fn>\n===== asynchronous gap ===========================\ndart:async/zone.dart 1118:19                                   _CustomZone.registerUnaryCallback\ndart:async-patch/async_patch.dart 40:23                        _asyncThenWrapperHelper\npackage:test_api/src/backend/invoker.dart                      Invoker._onRun.<fn>.<fn>.<fn>\ndart:async/zone.dart 1186:13                                   _rootRun\ndart:async/zone.dart 1090:19                                   _CustomZone.run\ndart:async/zone.dart 1626:10                                   _runZoned\ndart:async/zone.dart 1546:10                                   runZoned\npackage:test_api/src/backend/invoker.dart 370:9                Invoker._onRun.<fn>.<fn>\npackage:test_api/src/backend/invoker.dart 415:15               Invoker._guardIfGuarded\npackage:test_api/src/backend/invoker.dart 369:7                Invoker._onRun.<fn>\npackage:stack_trace/src/chain.dart 94:24                       Chain.capture.<fn>\ndart:async/zone.dart 1186:13                                   _rootRun\ndart:async/zone.dart 1090:19                                   _CustomZone.run\ndart:async/zone.dart 1626:10                                   _runZoned\ndart:async/zone.dart 1546:10                                   runZoned\npackage:stack_trace/src/chain.dart 92:12                       Chain.capture\npackage:test_api/src/backend/invoker.dart 368:11               Invoker._onRun\npackage:test_api/src/backend/live_test_controller.dart 153:11  LiveTestController.run\ndart:async/future.dart 201:37                                  new Future.microtask.<fn>\npackage:stack_trace/src/stack_zone_specification.dart 208:15   StackZoneSpecification._run\npackage:stack_trace/src/stack_zone_specification.dart 116:48   StackZoneSpecification._registerCallback.<fn>\ndart:async/zone.dart 1178:47                                   _rootRun\ndart:async/zone.dart 1090:19                                   _CustomZone.run\ndart:async/zone.dart 994:7                                     _CustomZone.runGuarded\ndart:async/zone.dart 1034:23                                   _CustomZone.bindCallbackGuarded.<fn>\npackage:stack_trace/src/stack_zone_specification.dart 208:15   StackZoneSpecification._run\npackage:stack_trace/src/stack_zone_specification.dart 116:48   StackZoneSpecification._registerCallback.<fn>\ndart:async/zone.dart 1186:13                                   _rootRun\ndart:async/zone.dart 1090:19                                   _CustomZone.run\ndart:async/zone.dart 994:7                                     _CustomZone.runGuarded\ndart:async/zone.dart 1034:23                                   _CustomZone.bindCallbackGuarded.<fn>\ndart:async/schedule_microtask.dart 41:21                       _microtaskLoop\ndart:async/schedule_microtask.dart 50:5                        _startMicrotaskLoop\n"}}

00:13 +9 -3: C:\b\s\w\ir\k\flutter\packages\integration_test\test\reporter\pass_then_fail_test.dart: when one test passes, then another fails                                                          
00:13 +9 -3: Some tests failed.                                                                                                                                                                        
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
ERROR: Last command exited with 1 (expected: zero).
Command: ..\..\bin\flutter.bat test
Relative working directory: packages\integration_test
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

… test results (#70075)" This reverts commit af5eb3b.

dnfield · 2020-11-13T17:13:22Z

LGTM.

@jiahaog - we probably need some path.join logic instead of raw paths in there, and use flutter.bat on Windows instead of flutter.

jiahaog · 2020-11-14T01:26:32Z

Yeah, I accidentally clobbered the changes you made to test/binding_fail_test.dart. Sorry for the trouble!

Revert "[integration_test] Add a run method for proper reporting of…

46572e2

… test results (#70075)" This reverts commit af5eb3b.

flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Nov 13, 2020

jonahwilliams requested a review from jiahaog November 13, 2020 17:01

google-cla bot added the cla: yes label Nov 13, 2020

jonahwilliams requested a review from dnfield November 13, 2020 17:01

jonahwilliams merged commit ed977dd into master Nov 13, 2020

jonahwilliams deleted the revert-70075-integration-test-reporter branch November 13, 2020 17:01

jonahwilliams mentioned this pull request Nov 13, 2020

Reverted [integration_test] Add a run method for proper reporting of test results #70467

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Revert "[integration_test] Add a `run` method for proper reporting of test results" #70466

Revert "[integration_test] Add a `run` method for proper reporting of test results" #70466

Uh oh!

jonahwilliams commented Nov 13, 2020

Uh oh!

dnfield commented Nov 13, 2020

Uh oh!

jiahaog commented Nov 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Revert "[integration_test] Add a run method for proper reporting of test results" #70466

Revert "[integration_test] Add a run method for proper reporting of test results" #70466

Uh oh!

Conversation

jonahwilliams commented Nov 13, 2020

Uh oh!

dnfield commented Nov 13, 2020

Uh oh!

jiahaog commented Nov 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Revert "[integration_test] Add a `run` method for proper reporting of test results" #70466

Revert "[integration_test] Add a `run` method for proper reporting of test results" #70466