Skip to content

[flutter_tools] make getBuildInfo async #70320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 4 commits into from
Nov 11, 2020
Merged

[flutter_tools] make getBuildInfo async #70320

jonahwilliams merged 4 commits into from
Nov 11, 2020

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Nov 11, 2020

Description

In preparation for a future change where package config is loaded once.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 11, 2020
@google-cla google-cla bot added the cla: yes label Nov 11, 2020
jmagman
jmagman approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams mentioned this pull request Nov 11, 2020
Merged
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Nov 11, 2020

this code is not used in g3, failure is unrelated

@jonahwilliams jonahwilliams merged commit 22ec357 into flutter:master Nov 11, 2020
@jonahwilliams jonahwilliams deleted the make_get_build_info_async branch November 11, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams @jmagman