🚀 AdoptAWidget: IgnorePointer#70185
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
The analyzer is unhappy with the trailing spaces. Could you please check it out? 🙂 |
Yup, sure I will! 🚀 |
|
I am trying to find the spaces but the lines it mentions have no trailing spaces, at least in vs code. When I select there is an extra highlight space but I can't remove and it is not space when moving with arrow keys. UPDATE: I could remove the spaces from the GitHub inline editor 🚀 |
johnpryan
left a comment
There was a problem hiding this comment.
Looks good overall, just a few suggestions.
|
(PR triage) @YazeedAlKhalaf do you have plans to follow up on the feedback? |
Yes, but I had so many quizzes last week and this week. Today I am free and will do the changes 🚀. |
|
For unknown reasons the tests keep failing (obviously incorrectly). Can you try by merging with the head and pushing again? |
Sure I will |
…t_a_widget_ignore_pointer
|
Can anybody help me with why is the test failing? |
|
I've restarted the tests in case of flakes. |
|
@YazeedAlKhalaf Thanks for participating in AdoptAWidget. We would like to send you a special thanks. If you are interested, please send an email to nyener at google dot com and provide a link to this issue. |
I have sent an email but no reply 😁🚀 |
AdoptAWidget: IgnorePointer
I have added a dartpad and reorganized the explanation.
This pull request is:
closes #69485