Skip to content

🚀 AdoptAWidget: IgnorePointer#70185

Merged
johnpryan merged 4 commits intoflutter:masterfrom
YazeedAlKhalaf:adopt_a_widget_ignore_pointer
Nov 23, 2020
Merged

🚀 AdoptAWidget: IgnorePointer#70185
johnpryan merged 4 commits intoflutter:masterfrom
YazeedAlKhalaf:adopt_a_widget_ignore_pointer

Conversation

@YazeedAlKhalaf
Copy link
Contributor

AdoptAWidget: IgnorePointer

I have added a dartpad and reorganized the explanation.

This pull request is:

  • A code sample
  • More references
  • More explanation

closes #69485

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Nov 10, 2020
@google-cla google-cla bot added the cla: yes label Nov 10, 2020
@JuYeong0413
Copy link
Contributor

The analyzer is unhappy with the trailing spaces. Could you please check it out? 🙂

@YazeedAlKhalaf
Copy link
Contributor Author

The analyzer is unhappy with the trailing spaces. Could you please check it out? 🙂

Yup, sure I will! 🚀

@YazeedAlKhalaf
Copy link
Contributor Author

YazeedAlKhalaf commented Nov 11, 2020

I am trying to find the spaces but the lines it mentions have no trailing spaces, at least in vs code. When I select there is an extra highlight space but I can't remove and it is not space when moving with arrow keys.

UPDATE: I could remove the spaces from the GitHub inline editor 🚀

Copy link
Contributor

@johnpryan johnpryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few suggestions.

@HansMuller HansMuller requested a review from dkwingsmt November 13, 2020 00:59
@goderbauer
Copy link
Member

(PR triage) @YazeedAlKhalaf do you have plans to follow up on the feedback?

@YazeedAlKhalaf
Copy link
Contributor Author

(PR triage) @YazeedAlKhalaf do you have plans to follow up on the feedback?

Yes, but I had so many quizzes last week and this week. Today I am free and will do the changes 🚀.

Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkwingsmt
Copy link
Contributor

For unknown reasons the tests keep failing (obviously incorrectly). Can you try by merging with the head and pushing again?

@YazeedAlKhalaf
Copy link
Contributor Author

For unknown reasons the tests keep failing (obviously incorrectly). Can you try by merging with the head and pushing again?

Sure I will

@YazeedAlKhalaf
Copy link
Contributor Author

Can anybody help me with why is the test failing?

@dkwingsmt
Copy link
Contributor

I've restarted the tests in case of flakes.

@johnpryan johnpryan merged commit bcdee0a into flutter:master Nov 23, 2020
@johnpryan
Copy link
Contributor

@YazeedAlKhalaf Thanks for participating in AdoptAWidget. We would like to send you a special thanks. If you are interested, please send an email to nyener at google dot com and provide a link to this issue.

@YazeedAlKhalaf
Copy link
Contributor Author

YazeedAlKhalaf commented Nov 30, 2020

@YazeedAlKhalaf Thanks for participating in AdoptAWidget. We would like to send you a special thanks. If you are interested, please send an email to nyener at google dot com and provide a link to this issue.

I have sent an email but no reply 😁🚀
@johnpryan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt a Widget - IgnorePointer

5 participants