Skip to content

Roll engine and fix pubspecs that do not have a Dart SDK constraint #70078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mit-mit merged 12 commits into from
Nov 9, 2020
Merged

Roll engine and fix pubspecs that do not have a Dart SDK constraint #70078

mit-mit merged 12 commits into from
Nov 9, 2020

Conversation

@mit-mit
Copy link
Member

@mit-mit mit-mit commented Nov 9, 2020 •
edited
Loading

Description

Attempt to address the Dart breaking change that pubspec.yaml files must have a Dart SDK constraint.

Related Issues

Breaking change that causes this: dart-lang/sdk#44072

Previous fix for this: #70030

Failed roll after above fix: #70039

@flutter-dashboard flutter-dashboard bot added engine flutter/engine related. See also e: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Nov 9, 2020
@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 9, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Nov 9, 2020
@mit-mit mit-mit mentioned this pull request Nov 9, 2020
Closed
@jonasfj jonasfj mentioned this pull request Nov 9, 2020
Closed
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 9, 2020
@zanderso zanderso changed the title Fix pubspecs that do not have a Dart SDK constraint Roll engine and fix pubspecs that do not have a Dart SDK constraint Nov 9, 2020
zanderso
zanderso approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dev/benchmarks/metrics_center/lib/google_benchmark.dart

// This file uses Dart 2.12 semantics. This is needed as we can't upgrade
// the SDK constraint to `>=2.12.0-0` before the deps are ready.
// @dart=2.12
Copy link
Member

@zanderso zanderso Nov 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @liyuqian

@zanderso
Copy link
Member

zanderso commented Nov 9, 2020

Tool tests are failing due to a missing constraint here:

https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/integration.shard/test_data/stepping_project.dart#L9

cbracken
cbracken approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! lgtm.

@mit-mit mit-mit merged commit 168ad5d into flutter:master Nov 9, 2020
@mit-mit mit-mit deleted the newpub branch November 9, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken approved these changes

@zanderso zanderso zanderso approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mit-mit @zanderso @cbracken