Skip to content

[flutter_tools] wrap http send in async guard#69972

Merged
jonahwilliams merged 2 commits intoflutter:masterfrom
jonahwilliams:async_grd
Nov 6, 2020
Merged

[flutter_tools] wrap http send in async guard#69972
jonahwilliams merged 2 commits intoflutter:masterfrom
jonahwilliams:async_grd

Conversation

@jonahwilliams
Copy link
Contributor

Description

Work around package:http crashing the crash reporter when certain requests fail.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 6, 2020
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Nov 6, 2020
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonahwilliams jonahwilliams merged commit 1f21027 into flutter:master Nov 6, 2020
@jonahwilliams jonahwilliams deleted the async_grd branch November 6, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants