Skip to content

[flutter_tools] work around bug in plugins CI#69971

Merged
jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams:remove_dashdash_from_forward
Nov 6, 2020
Merged

[flutter_tools] work around bug in plugins CI#69971
jonahwilliams merged 1 commit intoflutter:masterfrom
jonahwilliams:remove_dashdash_from_forward

Conversation

@jonahwilliams
Copy link
Contributor

Description

Some commands in plugins are passing an extra --.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 6, 2020
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Nov 6, 2020
@christopherfujino
Copy link
Contributor

For posterity, here's a failure: https://cirrus-ci.com/task/5538595224158208

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit ef288c1 into flutter:master Nov 6, 2020
@jonahwilliams jonahwilliams deleted the remove_dashdash_from_forward branch November 6, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants