Skip to content

remove the use of the analysis server --enable-experiments flag#69966

Merged
jonahwilliams merged 1 commit intoflutter:masterfrom
devoncarew:remove_analysis_server_flag
Nov 6, 2020
Merged

remove the use of the analysis server --enable-experiments flag#69966
jonahwilliams merged 1 commit intoflutter:masterfrom
devoncarew:remove_analysis_server_flag

Conversation

@devoncarew
Copy link
Contributor

@devoncarew devoncarew commented Nov 6, 2020

Description

This removes the use of the analysis server's --enable-experiment flag. The flag as been removed upstream, and passing it in will likely fail.

The flag had only been intended for dev time uses, like testing (users should configure analysis for language experiments via the analysis_options.yaml file).

Related Issues

  • none

Tests

I added the following tests:

  • I updated the existing tests

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 6, 2020
@google-cla google-cla bot added the cla: yes label Nov 6, 2020
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit 5ba2d79 into flutter:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants