Skip to content

[null-safety] remove enable experiment flags#69930

Merged
jonahwilliams merged 4 commits intoflutter:masterfrom
jonahwilliams:remove_enable_experiment_12321213
Nov 6, 2020
Merged

[null-safety] remove enable experiment flags#69930
jonahwilliams merged 4 commits intoflutter:masterfrom
jonahwilliams:remove_enable_experiment_12321213

Conversation

@jonahwilliams
Copy link
Contributor

Description

Make sure the language constraints are working correctly

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Nov 6, 2020
@google-cla google-cla bot added the cla: yes label Nov 6, 2020
// found in the LICENSE file.

// @dart=2.10
// @dart = 2.12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these non-opt-out ones necessary anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the integration_test/web package hasn't been migrated and I didn't really want to do that as part of this PR. I don't think the changes would be big

Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonahwilliams jonahwilliams merged commit 6fe800a into flutter:master Nov 6, 2020
@jonahwilliams jonahwilliams deleted the remove_enable_experiment_12321213 branch November 6, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants