Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chunhtai
left a comment
There was a problem hiding this comment.
Change looks good, but we need a test.
|
(PR triage): @sysint64 do you have plans to add a test soon as per feedback above? |
Yes, I'm planning to do this in couple days |
7c220a1 to
17ae880
Compare
|
@chunhtai @goderbauer I have added the test. |
42d6fa1 to
aeb34fa
Compare
e44a145 to
55210bd
Compare
|
Hi @sysint64 can you rebase off master? this branch seems to be out of date. |
|
@chunhtai, I've rebased before I push changes. I checked it, and it's up to date. |
55210bd to
0ee68d5
Compare
0ee68d5 to
c57ee44
Compare
Description
The reason why is simple - we transited barrier color from
barrierColorto0x00000000, therefore we smoothly transit from black transparent to thebarrierColor, but this is not desirable behavior. For example, if we would like to use a white barrier color, it will be like this 0x00000000 -> 0xFFFFFFFF, but a desirable transition would be 0x00FFFFFF -> 0xFFFFFFFF.Related Issues
This PR fixes #24469, #67354.