Reland "Updated SearchDelegate to follow custom InputDecorationTheme"#69653
Merged
fluttergithubbot merged 4 commits intoflutter:masterfrom Nov 6, 2020
darrenaustin:search_delegate_reland
Merged
Reland "Updated SearchDelegate to follow custom InputDecorationTheme"#69653fluttergithubbot merged 4 commits intoflutter:masterfrom darrenaustin:search_delegate_reland
fluttergithubbot merged 4 commits intoflutter:masterfrom
darrenaustin:search_delegate_reland
Conversation
HansMuller
approved these changes
Nov 3, 2020
Contributor
HansMuller
left a comment
There was a problem hiding this comment.
LGTM but you'll need to make the analyzer happy
Contributor
Author
|
There were still some internal failures being reported, but appeared to be unrelated null safety issues that were caused by the roll being behind. I went ahead and marked it as a success so we can land this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a relanding of #55209 which was reverted due to some internal test failures. These have been resolved on the internal side and we should be good to go.