Move package:integration_test to flutter/flutter #69622
Conversation
|
This is going to require a large number of analysis changes. :( |
|
Windows framework_tests is a flake - filed #69922 |
|
I think this is passing CI now and is ready for review. |
packages/integration_test/.gitignore
Outdated
| @@ -0,0 +1,7 @@ | |||
| .DS_Store | |||
There was a problem hiding this comment.
I think there is a global gitignore that will handle this
packages/integration_test/.metadata
Outdated
| @@ -0,0 +1,10 @@ | |||
| # This file tracks properties of this Flutter project. | |||
There was a problem hiding this comment.
this could be deleted
| @@ -0,0 +1,221 @@ | |||
| ## 0.9.2+2 | |||
There was a problem hiding this comment.
What should we do with the version changelog now that this no longer has a version number?
There was a problem hiding this comment.
I'd like to keep this here for historical purposes, but I don't think we'll keep updating the changelog. I can add a notice.
| @@ -0,0 +1,10 @@ | |||
| # This file tracks properties of this Flutter project. | |||
|
Precache failure is a flake unrelated to this PR. |
jonahwilliams
left a comment
There was a problem hiding this comment.
Overall LGTM for moving integration_test.
I did not closely review the code itself as it is being copied as-is for the most part
This will resolve issues around circular dependency management. It will also make sure that the integration_test package is tied tightly to API changes in the Flutter SDK at a specific version.
@nturgut @yjbanov @jonahwilliams