Skip to content

Remove the flaky flag from post-bdf benchmark#69591

Merged
fluttergithubbot merged 2 commits intoflutter:masterfrom
flar:deflake-post-backdropfilter-benchmark
Nov 6, 2020
Merged

Remove the flaky flag from post-bdf benchmark#69591
fluttergithubbot merged 2 commits intoflutter:masterfrom
flar:deflake-post-backdropfilter-benchmark

Conversation

@flar
Copy link
Contributor

@flar flar commented Nov 2, 2020

This benchmark has been marked flaky for some time because it was a frequent source of disconnects.

Recently it has had about 30 clean runs in a row, starting with e444b1e, so I am removing the flaky flag.

Fixes #59238

@flar flar requested a review from liyuqian November 2, 2020 18:56
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Nov 2, 2020
@google-cla google-cla bot added the cla: yes label Nov 2, 2020
Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flar flar force-pushed the deflake-post-backdropfilter-benchmark branch from 7ecb271 to 0f06c85 Compare November 2, 2020 21:16
@fluttergithubbot fluttergithubbot merged commit b8d21ad into flutter:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable post_backdrop_filter_perf_ios__timeline_summary once the appropriate tools are in place.

3 participants