[flutter_tools] add canvaskit hot reload integration test #69550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhatb
reviewed
Nov 2, 2020
| bool singleWidgetReloads = false, | ||
| File pidFile, | ||
| String script, | ||
| List<String> args, |
Contributor
There was a problem hiding this comment.
intentional or test code? Please add comment for args otherwise
Contributor
Author
There was a problem hiding this comment.
Its all test code, but i changed the name to be more descriptive.
Contributor
Author
|
Landing this with the retries to kick the tree. We're currently closed on web hot restart tests and I want to make sure they're passing at least some of the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a hot reload integration test for canvaskit. Currently skipped due to failures.