Skip to content

AdoptAWidget: Tooltip #69518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 4 commits into from
Nov 1, 2020
Merged

AdoptAWidget: Tooltip #69518

fluttergithubbot merged 4 commits into from
Nov 1, 2020

Conversation

@tsvillain
Copy link
Contributor

@tsvillain tsvillain commented Nov 1, 2020

DartPad Sample added in Tooltip API docs

This pull request is:

  • A code sample

closes #69489

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Nov 1, 2020
@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 1, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Nov 1, 2020
tsvillain and others added 2 commits November 1, 2020 14:31
@tsvillain
Apply suggestions from code review
230f89a 
Co-authored-by: Shi-Hao Hong <shihaohong@google.com>
@tsvillain
message and text updated
322f6d4
@tsvillain tsvillain requested a review from shihaohong November 1, 2020 09:13
shihaohong
shihaohong approved these changes Nov 1, 2020
View reviewed changes
Copy link
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a tiny grammar nitpick

@tsvillain
Update packages/flutter/lib/src/material/tooltip.dart
41953d0 
Co-authored-by: Shi-Hao Hong <shihaohong@google.com>
shihaohong
shihaohong reviewed Nov 1, 2020
View reviewed changes
Copy link
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some suggestions and some corrections

@tsvillain
Copy link
Contributor Author

tsvillain commented Nov 1, 2020

Have some suggestions and some corrections

Thank you for your correction and suggestions will update the PR accordingly.

@fluttergithubbot fluttergithubbot merged commit 5511abd into flutter:master Nov 1, 2020
@johnpryan
Copy link
Contributor

johnpryan commented Nov 11, 2020

@tsvillain Thanks for participating in AdoptAWidget. We would like to send you a special thanks. If you are interested, please send an email to nyener at google dot com and provide a link to this issue.

@tsvillain
Copy link
Contributor Author

tsvillain commented Nov 12, 2020

@johnpryan thank you for this.
I'll get in touch.
I will make more contributions to this framework 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shihaohong shihaohong shihaohong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adopt a Widget - Tooltip

4 participants

@tsvillain @johnpryan @shihaohong @fluttergithubbot