Skip to content

AdoptAWidget: aspectRatio #69509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 5 commits into from
Nov 1, 2020
Merged

AdoptAWidget: aspectRatio #69509

fluttergithubbot merged 5 commits into from
Nov 1, 2020

Conversation

@Amitpatil215
Copy link
Contributor

@Amitpatil215 Amitpatil215 commented Nov 1, 2020

AdoptAWidget: aspectRatio

This pull request is:

  • A code sample
  • More references
  • More explanation

closes #69483

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Nov 1, 2020
@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 1, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Nov 1, 2020
shihaohong
shihaohong reviewed Nov 1, 2020
View reviewed changes
Copy link
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing spaces to get analyzer to pass (Have not reviewed the sample itself yet)

Amitpatil215 and others added 2 commits November 1, 2020 09:32
@Amitpatil215
Fixed trailing spaces packages/flutter/lib/src/widgets/basic.dart at …
ff07b2f 
…2813

Co-authored-by: Shi-Hao Hong <shihaohong@google.com>
@Amitpatil215
Fixed trailing spaces packages/flutter/lib/src/widgets/basic.dart at …
63aa685 
…2840

Co-authored-by: Shi-Hao Hong <shihaohong@google.com>
shihaohong
shihaohong suggested changes Nov 1, 2020
View reviewed changes
@Amitpatil215
Improvement in color scheme and explanation.
96037ad 
Co-authored-by: Shi-Hao Hong <shihaohong@google.com>
@shihaohong
Copy link
Contributor

shihaohong commented Nov 1, 2020

Also, still failing on some trailing spaces: https://github.com/flutter/flutter/pull/69509/checks?check_run_id=1337729031

shihaohong
shihaohong approved these changes Nov 1, 2020
View reviewed changes
Copy link
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@fluttergithubbot fluttergithubbot merged commit 72025f0 into flutter:master Nov 1, 2020
@johnpryan
Copy link
Contributor

johnpryan commented Nov 11, 2020

@Amitpatil215 Thanks for participating in AdoptAWidget. We would like to send you a special thanks. If you are interested, please send an email to nyener at google dot com and provide a link to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shihaohong shihaohong shihaohong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adopt a Widget - AspectRatio

4 participants

@Amitpatil215 @shihaohong @johnpryan @fluttergithubbot