Skip to content

Conversation

@christopherfujino
Copy link
Contributor

Explicitly call out the breaking changes page of the website in the README.

Copy link
Contributor

@timsneath timsneath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

README.md Outdated
mailing list.
mailing list or see the
[breaking changes](https://flutter.dev/docs/release/breaking-changes) page of
Flutter's official website.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably remove the 'of Flutter's official website' clause. End the sentence at 'page'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

@Hixie
Copy link
Contributor

Hixie commented Oct 30, 2020

LGTM. I'd also be happy with us removing the mention of the mailing list, but that may be a bigger discussion.

@fluttergithubbot fluttergithubbot merged commit 156be1d into flutter:master Oct 30, 2020
@christopherfujino christopherfujino deleted the add-breaking-changes-link-to-readme branch November 2, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants