Skip to content

Roll Engine from 99cc50dfffab to 8d3d953192aa #69418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 1 commit into from
Oct 30, 2020
Merged

Roll Engine from 99cc50dfffab to 8d3d953192aa #69418

jonahwilliams merged 1 commit into from
Oct 30, 2020

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Oct 30, 2020

flutter/engine@99cc50d...8d3d953

2020-10-30 robert.ancell@canonical.com Fix warning when no entrypoing args provided. (flutter/engine#22136)
2020-10-30 robert.ancell@canonical.com Fix incorrect parameter used for self object (flutter/engine#22135)
2020-10-30 devoncarew@google.com use the dart analyze command to analyze source (flutter/engine#22212)
2020-10-30 10547444+lazylazyllama@users.noreply.github.com Fix viewInset.bottom and viewPadding.bottom… (flutter/engine#21730)
2020-10-30 a-siva@users.noreply.github.com Manual Roll of Dart to ba80ed989cc...9c6e76468ca (flutter/engine#22213)

@flutter-dashboard flutter-dashboard bot added the engine flutter/engine related. See also e: labels. label Oct 30, 2020
@google-cla google-cla bot added the cla: yes label Oct 30, 2020
jonahwilliams
jonahwilliams approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Oct 30, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux web_long_running_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows build_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows tool_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@zanderso zanderso force-pushed the pre-nnbd-manual-roll branch from dbc1e03 to 9dfd1bb Compare October 30, 2020 19:49
@jonahwilliams jonahwilliams merged commit bd121ec into master Oct 30, 2020
@jonahwilliams jonahwilliams deleted the pre-nnbd-manual-roll branch October 30, 2020 20:43
@kf6gpe kf6gpe mentioned this pull request Nov 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@a-siva a-siva a-siva approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zanderso @fluttergithubbot @a-siva @jonahwilliams