[null-safety] update tests and tool auto-detection for null safe dart #69405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Oct 30, 2020
| final LanguageVersion languageVersion = target != null | ||
| ? packageConfig?.packageOf(Uri.parse(target))?.languageVersion | ||
| : null; | ||
| final bool isNullSafe = languageVersion != null && languageVersion.major >= 2 && languageVersion.minor >= 11; |
Contributor
There was a problem hiding this comment.
A null language version is supposed to mean opt in, fwiw (it means current language version)
Contributor
Author
There was a problem hiding this comment.
Thanks - updated to be null safe if the language version is null or is gte 2.11
Contributor
There was a problem hiding this comment.
How are we going to handle the 2.12 flip here? That will be the sdk where its actually turned on
Contributor
Author
There was a problem hiding this comment.
I'll file an issue to adjust the constraints. This is only an approximation of the autodetect logic, so its going to have some holes.
…er into roll_1231212123asdas
jonahwilliams
commented
Oct 30, 2020
| ], | ||
| ); | ||
|
|
||
| // The flutter-tester device cannot be run concurrently in the same project directory. |
Contributor
Author
There was a problem hiding this comment.
I'm disabling these tests because they are timing out but only on CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes auto-detection of sound mode in web projects