Skip to content

Update FAB elevation to match spec#69312

Merged
guidezpl merged 7 commits intoflutter:masterfrom
guidezpl:spec-fab
Nov 26, 2020
Merged

Update FAB elevation to match spec#69312
guidezpl merged 7 commits intoflutter:masterfrom
guidezpl:spec-fab

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented Oct 29, 2020

Description

Updates FAB elevation to match Material spec.

Tests

I added the following tests:

  • a test to validate the elevation for different states

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. work in progress; do not review labels Oct 29, 2020
@google-cla google-cla bot added the cla: yes label Oct 29, 2020
@guidezpl guidezpl changed the title Update FAB to match spec Update FAB elevation to match spec Nov 26, 2020
@guidezpl guidezpl marked this pull request as ready for review November 26, 2020 13:48
Copy link
Contributor

@JoseAlba JoseAlba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

██╗      ██████╗ ████████╗███╗   ███╗
██║     ██╔════╝ ╚══██╔══╝████╗ ████║
██║     ██║  ███╗   ██║   ██╔████╔██║
██║     ██║   ██║   ██║   ██║╚██╔╝██║
███████╗╚██████╔╝   ██║   ██║ ╚═╝ ██║
╚══════╝ ╚═════╝    ╚═╝   ╚═╝     ╚═╝

Copy link
Contributor

@perclasson perclasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guidezpl guidezpl merged commit 183f0e7 into flutter:master Nov 26, 2020
@guidezpl guidezpl deleted the spec-fab branch November 26, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants