Skip to content

Revert "enable unnecessary_string_escapes and use_raw_strings" #68714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zanderso merged 1 commit into from
Oct 21, 2020
Merged

Revert "enable unnecessary_string_escapes and use_raw_strings" #68714

zanderso merged 1 commit into from
Oct 21, 2020

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Oct 21, 2020

Reverts #68302

Reverting due to bot redness and tree closure.

@zanderso zanderso requested a review from a14n October 21, 2020 15:15
@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 21, 2020
@google-cla google-cla bot added the cla: yes label Oct 21, 2020
@zanderso zanderso merged commit cbcd132 into master Oct 21, 2020
@zanderso zanderso deleted the revert-68302-string-lints branch October 21, 2020 15:16
@a14n
Copy link
Contributor

a14n commented Oct 21, 2020 •
edited
Loading

looks like the failures were unrelated to my PR

but LGTM

@zanderso
Copy link
Member Author

zanderso commented Oct 21, 2020

looks like the failures were unrelated to my PR

Sorry about that. If you could hold off on the reland until tomorrow that would be helpful. We're trying to limit commits to things related to nnbd at the moment while some fixes make their way up from Dart to the engine into the framework.

@a14n
Copy link
Contributor

a14n commented Oct 21, 2020

If you could hold off on the reland until tomorrow

ok I'll wait

After rerun failing jobs all succeeded

@a14n a14n mentioned this pull request Oct 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a14n a14n Awaiting requested review from a14n

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zanderso @a14n