Skip to content

[gen-l10n] Fix untranslated messages#68553

Merged
fluttergithubbot merged 8 commits intoflutter:masterfrom
shihaohong:fix-untranslated-messages
Nov 6, 2020
Merged

[gen-l10n] Fix untranslated messages#68553
fluttergithubbot merged 8 commits intoflutter:masterfrom
shihaohong:fix-untranslated-messages

Conversation

@shihaohong
Copy link
Contributor

Description

Fixes the following issues:

  • --untranslated-messages-file flag doesn't generate any file when all messages have already been translated. This PR now generates an empty JSON file when this is the case.
  • --gen-inputs-and-outputs-list file doesn't contain the untranslated-messages-file. It now will.
  • Only print message with missing translations status when unimplemented messages is empty
  • The deprecated path has been pointing to the wrong command (flutter generate-localizations instead of flutter gen-l10n). Since this has been broken for some time without any complaints, maybe it's a good time to remove it altogether.

Related Issues

Fixes #67138

Tests

I added the following tests:

  • A test to ensure that inputs and outputs list contains the untranslated messages file when specified
  • Tests to ensure that the untranslated messages file status correctly generated

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 20, 2020
@google-cla google-cla bot added the cla: yes label Oct 20, 2020
@shihaohong shihaohong added the a: internationalization Supporting other languages or locales. (aka i18n) label Oct 20, 2020
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that do not have a

@fluttergithubbot fluttergithubbot merged commit a1a096e into flutter:master Nov 6, 2020
@shihaohong shihaohong deleted the fix-untranslated-messages branch December 3, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: internationalization Supporting other languages or locales. (aka i18n) c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flutter gen-l10n untranslated messages warning false positive

3 participants