[gen-l10n] Fix untranslated messages#68553
Merged
fluttergithubbot merged 8 commits intoflutter:masterfrom Nov 6, 2020
shihaohong:fix-untranslated-messages
Merged
[gen-l10n] Fix untranslated messages#68553fluttergithubbot merged 8 commits intoflutter:masterfrom shihaohong:fix-untranslated-messages
fluttergithubbot merged 8 commits intoflutter:masterfrom
shihaohong:fix-untranslated-messages
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the following issues:
--untranslated-messages-fileflag doesn't generate any file when all messages have already been translated. This PR now generates an empty JSON file when this is the case.--gen-inputs-and-outputs-listfile doesn't contain the untranslated-messages-file. It now will.flutter generate-localizationsinstead offlutter gen-l10n). Since this has been broken for some time without any complaints, maybe it's a good time to remove it altogether.Related Issues
Fixes #67138
Tests
I added the following tests: