Skip to content

[devicelab] migrate defines test to DriverTest #68407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 2 commits into from
Oct 19, 2020
Merged

[devicelab] migrate defines test to DriverTest #68407

jonahwilliams merged 2 commits into from
Oct 19, 2020

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Oct 17, 2020

Description

Removes one-off handling for defines test and forces it to run through the DriverTest interface

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Oct 17, 2020
@google-cla google-cla bot added the cla: yes label Oct 17, 2020
jmagman
jmagman approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit 03db9bf into flutter:master Oct 19, 2020
@jonahwilliams jonahwilliams deleted the defines_to_driver_test branch October 19, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams @jmagman