Skip to content

request.mainUri should be fileUri #68329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingjun merged 1 commit into from
Oct 16, 2020
Merged

request.mainUri should be fileUri #68329

chingjun merged 1 commit into from
Oct 16, 2020
+70 −7

Conversation

@chingjun
Copy link
Contributor

@chingjun chingjun commented Oct 16, 2020

When filesystem scheme is used and when files other than entrypoint is updated, it couldn't be hot reloaded because the uri passed was incorrect.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 16, 2020
@google-cla google-cla bot added the cla: yes label Oct 16, 2020
jonahwilliams
jonahwilliams approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chingjun chingjun merged commit 583db83 into flutter:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chingjun @jonahwilliams