Skip to content

Sync lints #68136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 3 commits into from
Oct 15, 2020
Merged

Sync lints #68136

fluttergithubbot merged 3 commits into from
Oct 15, 2020

Conversation

@a14n
Copy link
Contributor

@a14n a14n commented Oct 14, 2020

Description

Sync lint list and enable:

I also :

  • replace default: with case XXX when a single case was left
  • remove default: when there was no chance to enter it.

Related Issues

None

Tests

None

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 14, 2020
@google-cla google-cla bot added the cla: yes label Oct 14, 2020
goderbauer
goderbauer reviewed Oct 14, 2020
View reviewed changes
packages/flutter_tools/lib/src/commands/create.dart Outdated
Copy link
Member

@goderbauer goderbauer Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this? If this is intentional, it probably deserves a comment.

packages/flutter_tools/lib/src/commands/ide_config.dart Outdated
Copy link
Member

@goderbauer goderbauer Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same.

goderbauer
goderbauer approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Oct 15, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux build_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

jonahwilliams
jonahwilliams approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tool changes LGTM

@fluttergithubbot fluttergithubbot merged commit 73301a3 into flutter:master Oct 15, 2020
@a14n a14n deleted the sync-lints branch October 16, 2020 04:14
@cbracken cbracken mentioned this pull request Oct 16, 2020
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@a14n @fluttergithubbot @goderbauer @jonahwilliams