Skip to content

[devicelab] delete disabled or not useful benchmarks #68107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 2 commits into from
Oct 14, 2020
Merged

[devicelab] delete disabled or not useful benchmarks #68107

jonahwilliams merged 2 commits into from
Oct 14, 2020
+0 −461

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Oct 14, 2020

Description

  • run_without_leak_tests: have been disabled for months
  • build_benchmark: the tooling work here is mostly done and we're not tracking further improvements, free up more devicelab capacity
  • system_debug_ios: does not work post iOS13
  • mac_enable_twc: not adding more mac tests to devicelab
  • hello_world_start_up: disabled

Any tests that we think will be valuable in the future can be resurrected from the git history.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Oct 14, 2020
@flutter-dashboard
Copy link

flutter-dashboard bot commented Oct 14, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Oct 14, 2020
@jonahwilliams jonahwilliams requested a review from dnfield October 14, 2020 16:12
dnfield
dnfield approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit 33903c1 into flutter:master Oct 14, 2020
@jonahwilliams jonahwilliams deleted the disable_tests branch October 14, 2020 17:30
@jmagman jmagman mentioned this pull request Oct 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonahwilliams @dnfield