Reland "More EditableText docs (#66864)" #68043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a57f45e.
Contributor
Author
|
|
LongCatIsLooong
commented
Oct 13, 2020
| // TODO(LongCatIsLooong): The if statement here is for retaining the | ||
| // previous behavior. The input formatter logic will be updated in an | ||
| // upcoming PR. | ||
| if (widget.inputFormatters?.isNotEmpty ?? false) |
Contributor
Author
There was a problem hiding this comment.
This is the only diff from the previous version.
The if statement seems unnecessary and I'll try to remove it in an upcoming PR.
renyou
approved these changes
Oct 13, 2020
Merged
|
Thanks! Looking forward to having this in the 1.22.3 release. #66144 is really the stopper of our project being upgraded to 1.22. May I ask do have a plan of cherry-picking this fix into beta / stable channel? @renyou @justinmc . https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a57f45e. Passed on TGP (the failures seem unrelated).
Description
Revert the whitespaceformatter change. It will be updated in a followup PR (that updates input formatter logic).
Related Issues
Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR. There should be at least one issue listed here.
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behavior with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.