Skip to content

Reland "Flutter Driver - Create widget finders from serialized finders extensions" with null safety #67711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dnfield merged 18 commits into from
Oct 9, 2020
Merged

Reland "Flutter Driver - Create widget finders from serialized finders extensions" with null safety #67711

dnfield merged 18 commits into from
Oct 9, 2020

Conversation

@marcin-jelenski
Copy link
Contributor

@marcin-jelenski marcin-jelenski commented Oct 9, 2020 •
edited
Loading

Description

As null safety feature for Flutter Driver was merged (#67570), we'd need to reland the extension feature patch (#67456). It should be compliant now, no lint nor build errors are reported.

Related Issues

#67570
#67456

Tests

  • packages/flutter_driver/test/src/real_tests/extension_test.dart

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Oct 9, 2020
@marcin-jelenski
Copy link
Contributor Author

marcin-jelenski commented Oct 9, 2020 •
edited
Loading

TBR @dnfield @goderbauer

@google-cla google-cla bot added the cla: yes label Oct 9, 2020
@marcin-jelenski marcin-jelenski changed the title Reland "Flutter Driver - Create widget finders from serialized finders extensions" Reland "Flutter Driver - Create widget finders from serialized finders extensions" with null safety Oct 9, 2020
@dnfield dnfield requested a review from jonahwilliams October 9, 2020 15:34
@dnfield
Copy link
Contributor

dnfield commented Oct 9, 2020

I think this should be fine, but @jonahwilliams can hopefully confirm

jonahwilliams
jonahwilliams suggested changes Oct 9, 2020
View reviewed changes
@marcin-jelenski
Copy link
Contributor Author

marcin-jelenski commented Oct 9, 2020

Fixes applied @jonahwilliams

jonahwilliams
jonahwilliams reviewed Oct 9, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you merged in a few other commits accidentally?

@marcin-jelenski
Copy link
Contributor Author

marcin-jelenski commented Oct 9, 2020

@jonahwilliams I've made a mistake during rebase. Fixed.

jonahwilliams
jonahwilliams approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcin-jelenski

This comment has been minimized.

Sign in to view
@dnfield
Copy link
Contributor

dnfield commented Oct 9, 2020

It should get merged when the tree becomes green again. Thanks for updating it.

@marcin-jelenski
Copy link
Contributor Author

marcin-jelenski commented Oct 9, 2020

It should get merged when the tree becomes green again. Thanks for updating it.

Exactly. Thank you for the review and cooperation.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Oct 9, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac build_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@marcin-jelenski
Copy link
Contributor Author

marcin-jelenski commented Oct 9, 2020

@dnfield it seems Mac builds were failing on the master, seems fine now. In the meantime the bot has removed the auto-merge label. May I ask for re-adding waiting for tree to go green?

@dnfield
Copy link
Contributor

dnfield commented Oct 9, 2020

It's passing now. @jonahwilliams - AFAICT the google internal failures are related to null-safety not being rolled into google3. I'm going to land this on that assumption. We can revert if I'm wrong.

@dnfield dnfield merged commit 759ddb1 into flutter:master Oct 9, 2020
This was referenced Oct 9, 2020
Merged
Closed
Open
Open
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marcin-jelenski @dnfield @fluttergithubbot @jonahwilliams