Stop logging on iOS process exit #66293
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
commented
Sep 21, 2020
| run.kill(); | ||
| }); | ||
| return passedTest && failedTest && skippedTest && finishedMessage | ||
| return passedTest && failedTest && skippedTest && finishedMessage && printMessage && writelnMessage |
Member
Author
There was a problem hiding this comment.
This fails on stable (neither line is printed).
| ..listen(receivedLogLines.add); | ||
|
|
||
| expect(await iosDeployDebugger.launchAndAttach(), isTrue); | ||
| await logLines.toList(); |
Contributor
There was a problem hiding this comment.
you could also await logLines.last
Member
Author
There was a problem hiding this comment.
Hm, it doesn't like that:
dart:async Stream.last
test/general.shard/ios/ios_deploy_test.dart 117:24 main.<fn>.<fn>.<fn>
===== asynchronous gap ===========================
dart:async _asyncThenWrapperHelper
test/general.shard/ios/ios_deploy_test.dart main.<fn>.<fn>.<fn>
dart:async runZoned
test/src/common.dart 207:14 testWithoutContext.<fn>
test/src/common.dart 177:18 test.<fn>
Bad state: No element
Contributor
There was a problem hiding this comment.
Ahh, because it is empty...
Contributor
There was a problem hiding this comment.
toList seems easier than Listen/onDone
Member
Author
There was a problem hiding this comment.
Getting the streams to work in these tests was 3x more work than the actual change.
Member
Author
|
Dependency #66092 was reverted. |
10 tasks
Member
Author
|
Closing, this was included with #66399. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Detect when an
exit()s and don't pass on further logging to the log reader. This pretty much never happens on iOS apps because the App Store will reject apps that exit themselves manually, but I did see it while I was writing integration tests.Related Issues
Follow up on #66092.
Tests
adblogging). Run on iOS, let's stop regressing logging on that platform...Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change