Prevent a potential infinite loop in setMessageHandler #66073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new test added in this PR would hang, because when you remove a message handler (by setting it to null) we tried to drain the messages, but since no handler was registered, we'd immediately add them back to the queue, which would then be drained, ad infinitum.
gaaclarke
approved these changes
Sep 17, 2020
Member
gaaclarke
left a comment
There was a problem hiding this comment.
LGTM, nit about nomenclature
| expect(envelope, isNull); | ||
| }); | ||
|
|
||
| test('can handle method call with no registered plugin (setting after)', () async { |
Member
There was a problem hiding this comment.
FWIW the title for this test is confusing to me. "registered plugin"? "registered handler?"
Contributor
Author
There was a problem hiding this comment.
heh, this is one reason why in my ideal test framework there's no test names. :-)
I think it refers to what happens when a method call comes in but no plugin has registered a handler for that channel.
Contributor
Author
There was a problem hiding this comment.
(the name is identical to the previous test, all I did was make a copy of the test with a minor tweak)
Member
There was a problem hiding this comment.
Feel free to change that one too, it's equally confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new test added in this PR would hang, because when you remove a message handler (by setting it to null) we tried to drain the messages, but since no handler was registered, we'd immediately add them back to the queue, which would then be drained, ad infinitum.