Skip to content

[flutter_tools] port deprecated settings test to flutter integration shard #65806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 1 commit into from
Sep 15, 2020
Merged

[flutter_tools] port deprecated settings test to flutter integration shard #65806

jonahwilliams merged 1 commit into from
Sep 15, 2020

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Sep 15, 2020 •
edited
Loading

Description

Port the deprecated settings devicelab test to tool integration shard. Tests that apps can be built using the deprecated android/settings.gradle file.

Part of #65790

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Sep 15, 2020
@jonahwilliams jonahwilliams marked this pull request as ready for review September 15, 2020 02:42
jmagman
jmagman approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit b88f308 into flutter:master Sep 15, 2020
@jonahwilliams jonahwilliams deleted the move_deprecated_gradle_test branch September 15, 2020 17:55
@jmagman jmagman mentioned this pull request Apr 8, 2021
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

+1 more reviewer

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonahwilliams @jmagman @blasten @googlebot