Skip to content

Reland "perf test for measuring scroll smoothness" #65602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Sep 11, 2020
Merged

Reland "perf test for measuring scroll smoothness" #65602

fluttergithubbot merged 1 commit into from
Sep 11, 2020

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Sep 11, 2020 •
edited
Loading

This relands #61998

This reverts commit 28de49e.

No extra change seems to be needed to avoid the test failures in the old reland, probably thanks to #65124. I tested with iPhone 6s both locally and remotely on flutter-devicelab-mac-1.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Sep 11, 2020
@liyuqian liyuqian changed the title [wip] Reland "perf test for measuring scroll smoothness" Reland "perf test for measuring scroll smoothness" Sep 11, 2020
@liyuqian liyuqian force-pushed the reland_resample_test branch from 6b0dca5 to a264be3 Compare September 11, 2020 06:10
@liyuqian
Revert the revert
c7c27e0 
This reverts commit 28de49e.
@liyuqian liyuqian force-pushed the reland_resample_test branch from a264be3 to c7c27e0 Compare September 11, 2020 18:18
@liyuqian
Copy link
Contributor Author

liyuqian commented Sep 11, 2020

CC @CareF as somehow I can't put you as the reviewer...

@CareF
Copy link
Contributor

CareF commented Sep 11, 2020 •
edited
Loading

@liyuqian Thanks and LGTM.
I believe that's because I've been removed from the hacker team :(

@liyuqian
Copy link
Contributor Author

liyuqian commented Sep 11, 2020

@CareF that must be an accident, and we apologize for that. Ray just added you back (sent you an invitation). Can you please check if it's received?

@CareF CareF self-requested a review September 11, 2020 19:35
CareF
CareF approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@CareF CareF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@liyuqian I received the invitation! Thanks.

jonahwilliams
jonahwilliams approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit e1eddb4 into flutter:master Sep 11, 2020
@liyuqian liyuqian deleted the reland_resample_test branch September 15, 2020 03:09
This was referenced Sep 16, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CareF CareF CareF approved these changes

@shihaohong shihaohong Awaiting requested review from shihaohong

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liyuqian @CareF @jonahwilliams @googlebot @fluttergithubbot