PR triage: @guidezpl @speaking-in-code Is this ready to be submitted? Or still waiting on anything?

"Google testing" is the last pending check. Not sure how long that normally takes, but it's been a few days now.

Other than that, AFAIK, this is good for submission now.

Good to merge after Google testing gets unstuck.

@renyou I was unable to manually test this PR on go/flutter-rob. Could you have a look?

Anything I can do to get the Google testing unstuck?

There were some genuine failed internal tests, I'll do some more digging this week to figure out the root cause

Alright, after doing some digging, it seems the bug still exists. I found two issues while using the repro case from the original issue.

1. flutter drive targeting a mobile device (I used a physical Android device) finds the isolate to be paused, and resumes it both with and without this PR with identical logs and failure.

VMServiceFlutterDriver: Isolate found with number: 2890840248319923
VMServiceFlutterDriver: Isolate is paused at start.
VMServiceFlutterDriver: Attempting to resume isolate
VMServiceFlutterDriver: Connected to Flutter application.
00:02 +0: Counter App starts at 0

00:02 +1: Counter App increments the counter

00:02 +1 -1: Counter App increments the counter [E]

  Expected: '1'
    Actual: '0'
     Which: is different.
            Expected: 1
              Actual: 0
                      ^
             Differ at offset 0
...

I think this is because the isolate spawned by final s = await compute(_test, 'hello'); never actually gets resumed and the following setState statement to increment the counter never gets executed.

2. flutter drive targeting macOS finds the isolate not to be paused. It currently runs correctly

VMServiceFlutterDriver: Isolate found with number: 3416477323685147
VMServiceFlutterDriver: Isolate is not paused. Assuming application is ready.
VMServiceFlutterDriver: Connected to Flutter application.
...
All tests passed

But with this PR, the additional attempt to resume fails hard, since the error is a StateError and not anrpc.RpcException.

VMServiceFlutterDriver: Isolate found with number: 3416477323685147
VMServiceFlutterDriver: Isolate is not paused. Assuming application is ready.
VMServiceFlutterDriver: Connected to Flutter application.
VMServiceFlutterDriver: Attempting to resume isolate
...
Original error: Bad state: The client closed with pending request "ext.flutter.driver".
...

If you'd like to continue work to try and find a solution to these, I encourage you to test against the original repro case. Testing against the gallery was a mistake on my part; Please don't hesitate to reach out to past contributors, who have much more knowledge about the driver than I do.

thanks @guidezpl. will try this out on more test cases to see if I can repro what you're seeing.

I've added an integration test for isolates to the flutter examples directory. Not sure if that's the right place for it, but having it around is useful.

The issues you found were fixed as follows:

1. The original Counter App + compute() integration test was brittle. It would not pass if there were async updates to the screen. That was fixed by making the test more robust.

2. MacOS threw a bit of a fit when trying to resume an unpaused isolate. The fix was not to do that.

One oddness I've encountered is isolate.pauseEvent being set to VMNoneEvent. That happens when I'm using the audio_service library, which is starting isolates from a flutter plugin on iOS and Android. I haven't been able to reproduce that with a simpler test case, so there's no integration test for that yet. If you have simple ideas for how to reproduce VMNoneEvent, let me know, I can try to add that test case as well.

I can see that the analyze-linux step has failed due to my changes. I'll clean that up tomorrow.

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.