Skip to content

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Jul 24, 2020

Description

Design Doc

Related Issues

#57218

Tests

Will need a bevy of tests, deferring for the moment to gather feedback on proposed API.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@Piinks Piinks added c: new feature Nothing broken; request for a new capability framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. work in progress; do not review customer: google Various Google teams customer: money (g3) labels Jul 24, 2020
@Piinks Piinks added the c: proposal A detailed proposal for a change to Flutter label Jul 27, 2020
@Piinks
Copy link
Contributor Author

Piinks commented Aug 11, 2020

I'm going to close this as I have branched off to make additional changes. This will be preserved and a new PR opened on the other branch. 👍

@Piinks Piinks closed this Aug 11, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: new feature Nothing broken; request for a new capability c: proposal A detailed proposal for a change to Flutter customer: google Various Google teams customer: money (g3) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants