Skip to content

1.17.5 CP: Fix daemon device discovery crash when Xcode isn't installed (#60546)#60611

Merged
pcsosinski merged 2 commits into
flutter:flutter-1.17-candidate.3from
pcsosinski:flutter-1.17-candidate.3
Jun 30, 2020
Merged

1.17.5 CP: Fix daemon device discovery crash when Xcode isn't installed (#60546)#60611
pcsosinski merged 2 commits into
flutter:flutter-1.17-candidate.3from
pcsosinski:flutter-1.17-candidate.3

Conversation

@pcsosinski

@pcsosinski pcsosinski commented Jun 30, 2020 •
edited
Loading

Copy link
Copy Markdown

@pcsosinski pcsosinski requested a review from jmagman June 30, 2020 16:19
@fluttergithubbot fluttergithubbot changed the base branch from flutter-1.17-candidate.3 to master June 30, 2020 16:19
@fluttergithubbot

fluttergithubbot commented Jun 30, 2020

Copy link
Copy Markdown
Contributor

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.17-candidate.3. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@pcsosinski pcsosinski changed the base branch from master to flutter-1.17-candidate.3 June 30, 2020 16:19
@fluttergithubbot fluttergithubbot added tool Affects the "flutter" command-line tool. See also t: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: examples Sample code and demos engine flutter/engine related. See also e: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 30, 2020
jmagman
jmagman approved these changes Jun 30, 2020
View reviewed changes

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcsosinski pcsosinski merged commit 8af6b2f into flutter:flutter-1.17-candidate.3 Jun 30, 2020
@pcsosinski pcsosinski deleted the flutter-1.17-candidate.3 branch June 30, 2020 20:37
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jmagman jmagman jmagman approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pcsosinski @fluttergithubbot @jmagman @googlebot