Skip to content

[flutter_tools] fix pm serve ipv6 linklocal addr issue #55664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 5 commits into from
Apr 29, 2020
Merged

[flutter_tools] fix pm serve ipv6 linklocal addr issue #55664

fluttergithubbot merged 5 commits into from
Apr 29, 2020

Conversation

@michaellee8
Copy link
Contributor

@michaellee8 michaellee8 commented Apr 26, 2020

Description

the patch from c5554cd removed the trailing information from the ipv6 addr, which is actually required for binding an ipv6 linklocal address in golang https://golang.org/pkg/net/#Dial. This patch reverts the changes that stripped out the require information, as well as reverting the change that escaped the % sign that breaks go's ipv6 addr resolution mechanism.

Related Issues

It is a trivial change so I didn't create an issue.

Tests

I added the following tests:

No test is included currently since the related part of the source is being actively changed.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 26, 2020
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Apr 26, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@michaellee8
Copy link
Contributor Author

michaellee8 commented Apr 26, 2020

@jonahwilliams @zanderso

@michaellee8
Copy link
Contributor Author

michaellee8 commented Apr 26, 2020

log before applying the patch

[  +27 ms] executing: [/home/michaellee8/flutter_fuchsia_toolchain/flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +34 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] 0c4a659d18ab37d9796ac68c552b1b4e790abd15
[        ] executing: [/home/michaellee8/flutter_fuchsia_toolchain/flutter/] git tag --contains HEAD
[ +188 ms] Exit code 0 from: git tag --contains HEAD
[   +2 ms] executing: [/home/michaellee8/flutter_fuchsia_toolchain/flutter/] git describe --match *.*.*-*.*.pre --first-parent --long --tags
[ +128 ms] Exit code 0 from: git describe --match *.*.*-*.*.pre --first-parent --long --tags
[        ] 1.18.0-8.0.pre-12-g0c4a659d1
[   +8 ms] executing: [/home/michaellee8/flutter_fuchsia_toolchain/flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[   +4 ms] Exit code 128 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] fatal: HEAD does not point to a branch
[  +44 ms] executing: [/home/michaellee8/flutter_fuchsia_toolchain/flutter/] git rev-parse --abbrev-ref HEAD
[   +4 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] HEAD
[  +37 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[   +9 ms] executing: /home/michaellee8/Android/Sdk/platform-tools/adb devices -l
[   +6 ms] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/device-finder list -full
[  +33 ms] List of devices attached
[ +993 ms] fe80::5054:ff:fe63:5e7a%qemu step-atom-yard-juicy
[   +6 ms] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/device-finder resolve -device-limit 1 step-atom-yard-juicy
[  +29 ms] fe80::5054:ff:fe63:5e7a%qemu
[   +7 ms] executing: ssh -F /home/michaellee8/.fuchsia/sshconfig fe80::5054:ff:fe63:5e7a%qemu uname -m
[  +83 ms] x86_64

           Warning: Permanently added 'fe80::5054:ff:fe63:5e7a%qemu' (ED25519) to the list of known hosts.
[   +2 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +1 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ +231 ms] Found plugin package_info at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/package_info-0.4.0+16/
[   +7 ms] Found plugin path_provider at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/path_provider-1.6.5/
[   +1 ms] Found plugin path_provider_macos at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/path_provider_macos-0.0.4/
[  +13 ms] Found plugin shared_preferences at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/shared_preferences-0.5.6+3/
[   +2 ms] Found plugin shared_preferences_macos at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/shared_preferences_macos-0.0.1+6/
[   +2 ms] Found plugin shared_preferences_web at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/shared_preferences_web-0.1.2+4/
[  +16 ms] Found plugin url_launcher at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/url_launcher-5.4.2/
[   +2 ms] Found plugin url_launcher_macos at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/url_launcher_macos-0.0.1+4/
[   +2 ms] Found plugin url_launcher_web at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/url_launcher_web-0.1.1+1/
[  +99 ms] Found plugin package_info at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/package_info-0.4.0+16/
[   +1 ms] Found plugin path_provider at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/path_provider-1.6.5/
[        ] Found plugin path_provider_macos at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/path_provider_macos-0.0.4/
[   +5 ms] Found plugin shared_preferences at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/shared_preferences-0.5.6+3/
[        ] Found plugin shared_preferences_macos at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/shared_preferences_macos-0.0.1+6/
[   +1 ms] Found plugin shared_preferences_web at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/shared_preferences_web-0.1.2+4/
[  +35 ms] Found plugin url_launcher at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/url_launcher-5.4.2/
[   +3 ms] Found plugin url_launcher_macos at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/url_launcher_macos-0.0.1+4/
[   +3 ms] Found plugin url_launcher_web at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/url_launcher_web-0.1.1+1/
[  +85 ms] Generating /home/michaellee8/gallery/android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java
[  +47 ms] executing: ssh -F /home/michaellee8/.fuchsia/sshconfig fe80::5054:ff:fe63:5e7a%qemu cat /pkgfs/packages/build-info/0/data/version
[  +24 ms] 0.20200425.0.1
[ +102 ms] Launching lib/main.dart on step-atom-yard-juicy in debug mode...
[   +7 ms] /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/dart-sdk/bin/dart /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/engine/linux-x64/frontend_server.dart.snapshot
--sdk-root /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/flutter_runner/flutter/x64/debug/jit/flutter_runner_patched_sdk/ --incremental --target=flutter_runner --debugger-module-names
-Ddart.developer.causal_async_stacks=true --output-dill /tmp/flutter_tool.VCDUKD/app.dill --packages .packages -Ddart.vm.profile=false -Ddart.vm.product=false
--bytecode-options=source-positions,local-var-info,debugger-stops,instance-field-initializers,keep-unreachable-code,avoid-closure-call-instructions --enable-asserts --track-widget-creation --filesystem-scheme
org-dartlang-root --initialize-from-dill build/cache.dill
[  +32 ms] <- compile package:gallery/main.dart
[  +10 ms] Building Fuchsia application...
[   +2 ms] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/dart-sdk/bin/dart
/home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/flutter_runner/flutter/arm64/debug/jit/dart_binaries/kernel_compiler.snapshot --target flutter_runner --platform
/home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/flutter_runner/flutter/arm64/debug/jit/flutter_runner_patched_sdk/platform_strong.dill --filesystem-scheme main-root --filesystem-root
/home/michaellee8/gallery --packages main-root:///.packages --output build/fuchsia/gallery.dil --component-name gallery --no-link-platform --split-output-by-packages --manifest build/fuchsia/gallery.dilpmanifest
--embed-sources -Ddart.developer.causal_async_stacks=true main-root:////home/michaellee8/gallery/lib/main.dart
[+28813 ms] Building Fuchsia application... (completed in 28.8s)
[        ] fuchsia-kernel-compile: 28820 ms.
[+1882 ms] fuchsia-build-assets: 1882 ms.
[  +24 ms] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/pm -o build/fuchsia/pkg -n gallery init
[  +16 ms] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/pm -o build/fuchsia/pkg -k build/fuchsia/pkg/development.key genkey
[   +9 ms] package signing is deprecated
[        ] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/pm -o build/fuchsia/pkg -k build/fuchsia/pkg/development.key -m build/fuchsia/pkg/package_manifest
build
[ +574 ms] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/pm -o build/fuchsia/pkg -k build/fuchsia/pkg/development.key -m build/fuchsia/pkg/package_manifest
archive
[ +228 ms] fuchsia-build-package: 850 ms.
[   +4 ms] executing: ssh -F /home/michaellee8/.fuchsia/sshconfig fe80::5054:ff:fe63:5e7a%qemu tiles_ctl list
[  +98 ms] Couldn't find tiles component in realm
           To start a new instance of tiles, run 'tiles_ctl start'
[        ] tiles_ctl is not running
[        ] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/device-finder resolve -local -device-limit 1 step-atom-yard-juicy
[  +20 ms] fe80::9c3a:6fff:feba:6e23%qemu
[  +10 ms] Starting Fuchsia application gallery...
[   +1 ms] executing: ssh -F /home/michaellee8/.fuchsia/sshconfig fe80::5054:ff:fe63:5e7a%qemu amber_ctl get_up -n tiles
[  +51 ms] executing: ssh -F /home/michaellee8/.fuchsia/sshconfig fe80::5054:ff:fe63:5e7a%qemu amber_ctl get_up -n tiles_ctl
[  +48 ms] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/pm newrepo -repo build/fuchsia/.pkg-repo
[ +540 ms] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/pm serve -repo build/fuchsia/.pkg-repo -l [fe80::9c3a:6fff:feba:6e23%25qemu]:43733
[   +5 ms] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/pm publish -a -r build/fuchsia/.pkg-repo -f build/fuchsia/pkg/gallery-0.far
[   +5 ms] listen tcp [fe80::9c3a:6fff:feba:6e23%25qemu]:43733: bind: no such device
[   +3 ms] Error running Fuchsia pm tool "serve" command
[ +556 ms] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/pm publish -a -r build/fuchsia/.pkg-repo -f
/home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/flutter_runner/flutter/x64/debug/jit/flutter_jit_runner-0.far
[ +437 ms] executing: ssh -F /home/michaellee8/.fuchsia/sshconfig fe80::5054:ff:fe63:5e7a%qemu amber_ctl add_repo_cfg -n flutter_tool -f http://[fe80::9c3a:6fff:feba:6e23%25qemu]:43733/config.json
[  +37 ms] 2020/04/26 03:25:53 error adding repo: failed to GET file: Get "http://[fe80::9c3a:6fff:feba:6e23%25qemu]:43733/config.json": dial tcp [fe80::9c3a:6fff:feba:6e23%qemu]:43733: errno(111)
[        ] Failed to teach amber about the package server
[        ] Shutting down the tool's package server.
[        ] Removing the tool's package repo: at build/fuchsia/.pkg-repo
[  +57 ms] Starting Fuchsia application gallery... (completed in 1.7s)
[        ] Error launching application on step-atom-yard-juicy.
[   +5 ms] "flutter run" took 35,372ms.

#0      throwToolExit (package:flutter_tools/src/base/common.dart:14:3)
#1      RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:570:7)
<asynchronous suspension>
#2      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:760:18)
<asynchronous suspension>
#3      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:657:33)
<asynchronous suspension>
#4      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart)
#5      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:29)
#6      _rootRun (dart:async/zone.dart:1184:13)
#7      _CustomZone.run (dart:async/zone.dart:1077:19)
#8      _runZoned (dart:async/zone.dart:1619:10)
#9      runZoned (dart:async/zone.dart:1539:10)
#10     AppContext.run (package:flutter_tools/src/base/context.dart:149:18)
#11     FlutterCommand.run (package:flutter_tools/src/runner/flutter_command.dart:647:20)
#12     CommandRunner.runCommand (package:args/command_runner.dart:197:27)
#13     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:339:21)
#14     _rootRunUnary (dart:async/zone.dart:1192:38)
#15     _CustomZone.runUnary (dart:async/zone.dart:1085:19)
#16     _FutureListener.handleValue (dart:async/future_impl.dart:141:18)
#17     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:686:45)
#18     Future._propagateToListeners (dart:async/future_impl.dart:715:32)
#19     Future._completeWithValue (dart:async/future_impl.dart:526:5)
#20     Future._asyncCompleteWithValue.<anonymous closure> (dart:async/future_impl.dart:560:7)
#21     _rootRun (dart:async/zone.dart:1184:13)
#22     _CustomZone.run (dart:async/zone.dart:1077:19)
#23     _CustomZone.runGuarded (dart:async/zone.dart:979:7)
#24     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1019:23)
#25     _microtaskLoop (dart:async/schedule_microtask.dart:43:21)
#26     _startMicrotaskLoop (dart:async/schedule_microtask.dart:52:5)
#27     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
#28     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:169:5)

log after applying the patch (still broken by this problem has been solved)

[  +18 ms] executing: [/home/michaellee8/flutter_fuchsia_toolchain/flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +52 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] 0c4a659d18ab37d9796ac68c552b1b4e790abd15
[   +1 ms] executing: [/home/michaellee8/flutter_fuchsia_toolchain/flutter/] git tag --contains HEAD
[ +319 ms] Exit code 0 from: git tag --contains HEAD
[   +6 ms] executing: [/home/michaellee8/flutter_fuchsia_toolchain/flutter/] git describe --match *.*.*-*.*.pre --first-parent --long --tags
[ +276 ms] Exit code 0 from: git describe --match *.*.*-*.*.pre --first-parent --long --tags
[        ] 1.18.0-8.0.pre-12-g0c4a659d1
[  +27 ms] executing: [/home/michaellee8/flutter_fuchsia_toolchain/flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +16 ms] Exit code 128 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] fatal: HEAD does not point to a branch
[  +64 ms] executing: [/home/michaellee8/flutter_fuchsia_toolchain/flutter/] git rev-parse --abbrev-ref HEAD
[  +20 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] HEAD
[  +75 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +4 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +30 ms] executing: /home/michaellee8/Android/Sdk/platform-tools/adb devices -l
[  +19 ms] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/device-finder list -full
[  +91 ms] List of devices attached
[ +986 ms] fe80::5054:ff:fe63:5e7a%qemu step-atom-yard-juicy
[   +3 ms] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/device-finder resolve -device-limit 1 step-atom-yard-juicy
[  +27 ms] fe80::5054:ff:fe63:5e7a%qemu
[   +7 ms] executing: ssh -F /home/michaellee8/.fuchsia/sshconfig fe80::5054:ff:fe63:5e7a%qemu uname -m
[ +185 ms] x86_64

                    Warning: Permanently added 'fe80::5054:ff:fe63:5e7a%qemu' (ED25519) to the list of known hosts.
[   +6 ms] Artifact Instance of 'AndroidMavenArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[ +345 ms] Found plugin package_info at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/package_info-0.4.0+16/
[  +14 ms] Found plugin path_provider at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/path_provider-1.6.5/
[   +4 ms] Found plugin path_provider_macos at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/path_provider_macos-0.0.4/
[  +41 ms] Found plugin shared_preferences at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/shared_preferences-0.5.6+3/
[   +3 ms] Found plugin shared_preferences_macos at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/shared_preferences_macos-0.0.1+6/
[   +7 ms] Found plugin shared_preferences_web at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/shared_preferences_web-0.1.2+4/
[  +41 ms] Found plugin url_launcher at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/url_launcher-5.4.2/
[   +2 ms] Found plugin url_launcher_macos at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/url_launcher_macos-0.0.1+4/
[   +4 ms] Found plugin url_launcher_web at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/url_launcher_web-0.1.1+1/
[ +165 ms] Found plugin package_info at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/package_info-0.4.0+16/
[   +2 ms] Found plugin path_provider at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/path_provider-1.6.5/
[   +1 ms] Found plugin path_provider_macos at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/path_provider_macos-0.0.4/
[  +13 ms] Found plugin shared_preferences at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/shared_preferences-0.5.6+3/
[   +1 ms] Found plugin shared_preferences_macos at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/shared_preferences_macos-0.0.1+6/
[   +3 ms] Found plugin shared_preferences_web at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/shared_preferences_web-0.1.2+4/
[  +19 ms] Found plugin url_launcher at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/url_launcher-5.4.2/
[   +1 ms] Found plugin url_launcher_macos at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/url_launcher_macos-0.0.1+4/
[   +4 ms] Found plugin url_launcher_web at /home/michaellee8/.pub-cache/hosted/pub.dartlang.org/url_launcher_web-0.1.1+1/
[ +117 ms] Generating /home/michaellee8/gallery/android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java
[  +56 ms] executing: ssh -F /home/michaellee8/.fuchsia/sshconfig fe80::5054:ff:fe63:5e7a%qemu cat /pkgfs/packages/build-info/0/data/version
[  +48 ms] 0.20200425.0.1
[  +68 ms] Launching lib/main.dart on step-atom-yard-juicy in debug mode...
[  +13 ms] /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/dart-sdk/bin/dart /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/engine/linux-x64/frontend_server.dart.snapshot
--sdk-root /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/flutter_runner/flutter/x64/debug/jit/flutter_runner_patched_sdk/ --incremental --target=flutter_runner --debugger-module-names
-Ddart.developer.causal_async_stacks=true --output-dill /tmp/flutter_tool.LFAPDD/app.dill --packages .packages -Ddart.vm.profile=false -Ddart.vm.product=false
--bytecode-options=source-positions,local-var-info,debugger-stops,instance-field-initializers,keep-unreachable-code,avoid-closure-call-instructions --enable-asserts --track-widget-creation --filesystem-scheme
org-dartlang-root --initialize-from-dill build/cache.dill
[  +53 ms] <- compile package:gallery/main.dart
[  +18 ms] Building Fuchsia application...
[   +3 ms] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/dart-sdk/bin/dart
/home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/flutter_runner/flutter/arm64/debug/jit/dart_binaries/kernel_compiler.snapshot --target flutter_runner --platform
/home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/flutter_runner/flutter/arm64/debug/jit/flutter_runner_patched_sdk/platform_strong.dill --filesystem-scheme main-root --filesystem-root
/home/michaellee8/gallery --packages main-root:///.packages --output build/fuchsia/gallery.dil --component-name gallery --no-link-platform --split-output-by-packages --manifest build/fuchsia/gallery.dilpmanifest
--embed-sources -Ddart.developer.causal_async_stacks=true main-root:////home/michaellee8/gallery/lib/main.dart
[+34022 ms] Building Fuchsia application... (completed in 34.0s)
[        ] fuchsia-kernel-compile: 34033 ms.
[+2014 ms] fuchsia-build-assets: 2013 ms.
[   +7 ms] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/pm -o build/fuchsia/pkg -n gallery init
[  +31 ms] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/pm -o build/fuchsia/pkg -k build/fuchsia/pkg/development.key genkey
[  +14 ms] package signing is deprecated
[        ] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/pm -o build/fuchsia/pkg -k build/fuchsia/pkg/development.key -m build/fuchsia/pkg/package_manifest
build
[ +362 ms] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/pm -o build/fuchsia/pkg -k build/fuchsia/pkg/development.key -m build/fuchsia/pkg/package_manifest
archive
[ +241 ms] fuchsia-build-package: 657 ms.
[   +3 ms] executing: ssh -F /home/michaellee8/.fuchsia/sshconfig fe80::5054:ff:fe63:5e7a%qemu tiles_ctl list
[ +778 ms] Couldn't find tiles component in realm
                    To start a new instance of tiles, run 'tiles_ctl start'
[        ] tiles_ctl is not running
[        ] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/device-finder resolve -local -device-limit 1 step-atom-yard-juicy
[  +24 ms] fe80::9c3a:6fff:feba:6e23%qemu
[   +8 ms] Starting Fuchsia application gallery...
[   +1 ms] executing: ssh -F /home/michaellee8/.fuchsia/sshconfig fe80::5054:ff:fe63:5e7a%qemu amber_ctl get_up -n tiles
[  +58 ms] executing: ssh -F /home/michaellee8/.fuchsia/sshconfig fe80::5054:ff:fe63:5e7a%qemu amber_ctl get_up -n tiles_ctl
[  +52 ms] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/pm newrepo -repo build/fuchsia/.pkg-repo
[ +794 ms] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/pm serve -repo build/fuchsia/.pkg-repo -l [fe80::9c3a:6fff:feba:6e23%qemu]:33773
[   +7 ms] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/pm publish -a -r build/fuchsia/.pkg-repo -f build/fuchsia/pkg/gallery-0.far
[   +6 ms] 2020-04-26 12:50:29 [pm serve] serving build/fuchsia/.pkg-repo at http://[fe80::9c3a:6fff:feba:6e23%qemu]:33773
[ +633 ms] executing: /home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/fuchsia/tools/pm publish -a -r build/fuchsia/.pkg-repo -f
/home/michaellee8/flutter_fuchsia_toolchain/flutter/bin/cache/artifacts/flutter_runner/flutter/x64/debug/jit/flutter_jit_runner-0.far
[ +888 ms] executing: ssh -F /home/michaellee8/.fuchsia/sshconfig fe80::5054:ff:fe63:5e7a%qemu amber_ctl add_repo_cfg -n flutter_tool -f http://[fe80::9c3a:6fff:feba:6e23%25qemu]:33773/config.json
[  +62 ms] 2020-04-26 12:50:31 [pm serve] 0 /config.json
[   +9 ms] executing: ssh -F /home/michaellee8/.fuchsia/sshconfig fe80::5054:ff:fe63:5e7a%qemu pkgctl resolve fuchsia-pkg://flutter_tool/gallery
[  +51 ms] resolving fuchsia-pkg://flutter_tool/gallery with the selectors []

           Error: INTERNAL
[        ] Failed to get pkgctl to prefetch the package
[   +2 ms] executing: ssh -F /home/michaellee8/.fuchsia/sshconfig fe80::5054:ff:fe63:5e7a%qemu pkgctl repo rm fuchsia-pkg://flutter_tool
[  +46 ms] Shutting down the tool's package server.
[        ] Removing the tool's package repo: at build/fuchsia/.pkg-repo
[  +41 ms] Starting Fuchsia application gallery... (completed in 2.7s)
[        ] Error launching application on step-atom-yard-juicy.
[   +7 ms] "flutter run" took 42,635ms.

#0      throwToolExit (package:flutter_tools/src/base/common.dart:14:3)
#1      RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:570:7)
<asynchronous suspension>
#2      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:760:18)
<asynchronous suspension>
#3      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:657:33)
<asynchronous suspension>
#4      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart)
#5      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:29)
#6      _rootRun (dart:async/zone.dart:1184:13)
#7      _CustomZone.run (dart:async/zone.dart:1077:19)
#8      _runZoned (dart:async/zone.dart:1619:10)
#9      runZoned (dart:async/zone.dart:1539:10)
#10     AppContext.run (package:flutter_tools/src/base/context.dart:149:18)
#11     FlutterCommand.run (package:flutter_tools/src/runner/flutter_command.dart:647:20)
#12     CommandRunner.runCommand (package:args/command_runner.dart:197:27)
#13     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:339:21)
#14     _rootRunUnary (dart:async/zone.dart:1192:38)
#15     _CustomZone.runUnary (dart:async/zone.dart:1085:19)
#16     _FutureListener.handleValue (dart:async/future_impl.dart:141:18)
#17     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:686:45)
#18     Future._propagateToListeners (dart:async/future_impl.dart:715:32)
#19     Future._completeWithValue (dart:async/future_impl.dart:526:5)
#20     Future._asyncCompleteWithValue.<anonymous closure> (dart:async/future_impl.dart:560:7)
#21     _rootRun (dart:async/zone.dart:1184:13)
#22     _CustomZone.run (dart:async/zone.dart:1077:19)
#23     _CustomZone.runGuarded (dart:async/zone.dart:979:7)
#24     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:1019:23)
#25     _microtaskLoop (dart:async/schedule_microtask.dart:43:21)
#26     _startMicrotaskLoop (dart:async/schedule_microtask.dart:52:5)
#27     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
#28     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:169:5)

@jonahwilliams
Copy link
Contributor

jonahwilliams commented Apr 26, 2020

FWIW, I patched this change to prevent an infra failure. I don't have the full context, but we can't simply revert the change otherwise our fuchsia integration test will break again.

[  +12 ms] executing: ssh -F /b/s/w/ir/fuchsia_ssh_config 192.168.42.104 tiles_ctl list
[  +72 ms] Found 1 tiles:
           Tile key 1 url fuchsia-pkg://fuchsia.com/terminal#meta/terminal.cmx size 1097.1x608.4x1000.0 (unfocusable)
[   +3 ms] Installing application package.
[   +1 ms] Starting application.
[  +57 ms] Building Fuchsia application...
[   +3 ms] executing: /b/s/w/ir/flutter/bin/cache/dart-sdk/bin/dart /b/s/w/ir/flutter/bin/cache/artifacts/flutter_runner/flutter/arm64/debug/jit/dart_binaries/kernel_compiler.snapshot --target flutter_runner --platform /b/s/w/ir/flutter/bin/cache/artifacts/flutter_runner/flutter/arm64/debug/jit/flutter_runner_patched_sdk/platform_strong.dill --filesystem-scheme main-root --filesystem-root /b/s/w/ir/flutter/dev/benchmarks/test_apps/stocks --packages main-root:///.packages --output build/fuchsia/stocks.dil --component-name stocks --no-link-platform --split-output-by-packages --manifest build/fuchsia/stocks.dilpmanifest --embed-sources -Ddart.developer.causal_async_stacks=true main-root:////b/s/w/ir/flutter/dev/benchmarks/test_apps/stocks/test_driver/stock_view.dart
[+16836 ms] Building Fuchsia application... (completed in 16.8s)
[        ] fuchsia-kernel-compile: 16854 ms.
[ +208 ms] fuchsia-build-assets: 207 ms.
[   +6 ms] executing: /b/s/w/ir/flutter/bin/cache/artifacts/fuchsia/tools/pm -o build/fuchsia/pkg -n stocks init
[  +12 ms] executing: /b/s/w/ir/flutter/bin/cache/artifacts/fuchsia/tools/pm -o build/fuchsia/pkg -k build/fuchsia/pkg/development.key genkey
[  +10 ms] package signing is deprecated
[        ] executing: /b/s/w/ir/flutter/bin/cache/artifacts/fuchsia/tools/pm -o build/fuchsia/pkg -k build/fuchsia/pkg/development.key -m build/fuchsia/pkg/package_manifest build
[ +224 ms] executing: /b/s/w/ir/flutter/bin/cache/artifacts/fuchsia/tools/pm -o build/fuchsia/pkg -k build/fuchsia/pkg/development.key -m build/fuchsia/pkg/package_manifest archive
[  +64 ms] fuchsia-build-package: 319 ms.
[        ] executing: ssh -F /b/s/w/ir/fuchsia_ssh_config 192.168.42.104 tiles_ctl list
[  +66 ms] Found 1 tiles:
           Tile key 1 url fuchsia-pkg://fuchsia.com/terminal#meta/terminal.cmx size 1097.1x608.4x1000.0 (unfocusable)
[        ] executing: /b/s/w/ir/flutter/bin/cache/artifacts/fuchsia/tools/device-finder resolve -local -device-limit 1 ocean-bats-wick-snub
[  +18 ms] fe80::ec4:7aff:fecc:ea8f%eno2

           mdns.go:1041: listen udp6 [2001:db8:123:4567:89ab:cdef:1234:1%docker0]:5353: bind: cannot assign requested address
           mdns.go:1041: listen udp6 [fe80::1%docker0]:5353: bind: cannot assign requested address
[  +20 ms] Starting Fuchsia application stocks...
[   +1 ms] executing: ssh -F /b/s/w/ir/fuchsia_ssh_config 192.168.42.104 amber_ctl get_up -n tiles
[  +56 ms] executing: ssh -F /b/s/w/ir/fuchsia_ssh_config 192.168.42.104 amber_ctl get_up -n tiles_ctl
[  +56 ms] executing: /b/s/w/ir/flutter/bin/cache/artifacts/fuchsia/tools/pm newrepo -repo build/fuchsia/.pkg-repo
[ +883 ms] executing: /b/s/w/ir/flutter/bin/cache/artifacts/fuchsia/tools/pm serve -repo build/fuchsia/.pkg-repo -l [fe80::ec4:7aff:fecc:ea8f%25eno2]:34283
[  +10 ms] executing: /b/s/w/ir/flutter/bin/cache/artifacts/fuchsia/tools/pm publish -a -r build/fuchsia/.pkg-repo -f build/fuchsia/pkg/stocks-0.far
[   +8 ms] listen tcp [fe80::ec4:7aff:fecc:ea8f%25eno2]:34283: bind: no such device
[   +4 ms] Error running Fuchsia pm tool "serve" command
[ +661 ms] executing: /b/s/w/ir/flutter/bin/cache/artifacts/fuchsia/tools/pm publish -a -r build/fuchsia/.pkg-repo -f /b/s/w/ir/flutter/bin/cache/artifacts/flutter_runner/flutter/x64/debug/jit/flutter_jit_runner-0.far
[ +726 ms] executing: ssh -F /b/s/w/ir/fuchsia_ssh_config 192.168.42.104 amber_ctl add_repo_cfg -n flutter_tool -f http://[fe80::ec4:7aff:fecc:ea8f%25eno2]:34283/config.json
[  +48 ms] 2020/04/25 01:14:37 error adding repo: failed to GET file: Get "http://[fe80::ec4:7aff:fecc:ea8f%25eno2]:34283/config.json": dial tcp [fe80::ec4:7aff:fecc:ea8f%eno2]:34283: errno(111)
[        ] Failed to teach amber about the package server
[        ] Shutting down the tool's package server.
[   +1 ms] Removing the tool's package repo: at build/fuchsia/.pkg-repo
[  +34 ms] Starting Fuchsia application stocks... (completed in 2.5s)
[   +8 ms] "flutter drive" took 21,828ms.
Application failed to start. Will not run test. Quitting.

@michaellee8
Copy link
Contributor Author

michaellee8 commented Apr 27, 2020

@jonahwilliams Are there any chance your integration test fail because you are running in Docker?

@jonahwilliams
Copy link
Contributor

jonahwilliams commented Apr 27, 2020

TBH I don't really understand this integration test very well, but it did start working again after I removed the information after the %.

Its a bit later here, but I'll cc some other folks on this PRs we can figure out the best solution.

@michaellee8
Copy link
Contributor Author

michaellee8 commented Apr 27, 2020

Okay I think I understand it now. Binding the ipv6 linklocal address on host require the unstripped address that include the interface name, but amber_ctl cannot accept the url with the interface. My proposed solution here is to add a interfaceStrippedUrl getter to be used by amber.

@michaellee8
Copy link
Contributor Author

michaellee8 commented Apr 27, 2020 •
edited
Loading

@jonahwilliams btw can you tell me how do I switch to different tiles in the fuchsia emulator? After applying this patch, it seems that flutter run is working now. However, there are still no application launching in the fuchsia emulator. Do you guys uses the workstation.qemu-x64-release or qemu-x64 flavour for using flutter run in the emulator? I read that you can do Select a Tab by Alt+F2, but I my Ubuntu environment all these keys are catched by the OS and perform tab switching on my desktop environment instead. What is the best way to do that?

Actually I am working on a toolchain to allow Flutter development on Fuchsia here https://github.com/michaellee8/flutter_fuchsia_toolchain

@michaellee8
Copy link
Contributor Author

michaellee8 commented Apr 28, 2020

After using the patch I can do flutter run in qemu-x64 now, because tiles_ctl exists there. However, how do I launch apps in workstation.qemu-x64-release? It seems that both tiles_ctl and sessionctl is not working there.

@zanderso
Copy link
Member

zanderso commented Apr 28, 2020

tiles_ctl was removed from the workstation image. My understanding is that https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=47125 is tracking its replacement.

@michaellee8
Copy link
Contributor Author

michaellee8 commented Apr 28, 2020 •
edited
Loading

tiles_ctl was removed from the workstation image. My understanding is that https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=47125 is tracking its replacement.

Thank you for your input but I don't really have access to that link. Can you tell me if there are no replacement yet? Or can you tell me more information about the replacement so that I can know when it lands by monitoring the commit history?

@michaellee8
Copy link
Contributor Author

michaellee8 commented Apr 28, 2020

I have rewrote the patch to avoid unnecessary changes. Tested to work with flutter run locally on my Ubuntu machine. Please see if it can be merged.

@michaellee8
Copy link
Contributor Author

michaellee8 commented Apr 28, 2020

It looks like the test are passing after I modified it reflect my changes. It should be ok to merge now.

@michaellee8
Copy link
Contributor Author

michaellee8 commented Apr 28, 2020

@jonahwilliams @zanderso

@jonahwilliams jonahwilliams requested a review from zanderso April 28, 2020 23:32
@fluttergithubbot fluttergithubbot merged commit 9d770c1 into flutter:master Apr 29, 2020
@michaellee8 michaellee8 mentioned this pull request Jun 17, 2021
Closed
8 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso zanderso approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@michaellee8 @fluttergithubbot @jonahwilliams @zanderso @googlebot