Skip to content

[windows] Adds support for keyboard mapping. #54227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 13 commits into from
Apr 8, 2020
Merged

[windows] Adds support for keyboard mapping. #54227

fluttergithubbot merged 13 commits into from
Apr 8, 2020

Conversation

@franciscojma86
Copy link
Contributor

@franciscojma86 franciscojma86 commented Apr 7, 2020

Description

Adds support for Windows keyboard, adding RawKeyEventDataWindows. The embedder counter part is a WIP PR.

Related Issues

#37710

Tests

Updated raw_keyboard_test.dart and the event simulator.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
    • I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
    • I got input from the developer relations team, specifically from: Replace with the names of who gave advice
    • I wrote a migration guide: Replace with a link to your migration guide

@fluttergithubbot fluttergithubbot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 7, 2020
@franciscojma86 franciscojma86 mentioned this pull request Apr 7, 2020
Merged
gspencergoog
gspencergoog approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

stuartmorgan-g
stuartmorgan-g approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tiny nits. Thanks for tackling this!

@googlebot
Copy link

googlebot commented Apr 8, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Apr 8, 2020
@franciscojma86
Copy link
Contributor Author

franciscojma86 commented Apr 8, 2020

@googlebot I fixed it.

@googlebot
Copy link

googlebot commented Apr 8, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Apr 8, 2020
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Apr 8, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite firebase_test_lab_tests-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit a0f7f6c into flutter:master Apr 8, 2020
@yjbanov
Copy link
Contributor

yjbanov commented Apr 8, 2020

This added 4KB of gzipped size to the "hello world" app when compiled to the web. Is it possible to use import ... as deferred so we don't eagerly load all the data? /cc @ferhatb who is looking at code size

Screen Shot 2020-04-08 at 1 30 09 PM

@ferhatb
Copy link
Contributor

ferhatb commented Apr 8, 2020

@yjbanov , the string based switch makes it untreeshakable. For web i filed an issue long ago to treeshake keymaps out. However, this must be adding to ios/android code size as well, is there a size_compile_test for those that shows regression as well ?

@mdebbar mdebbar mentioned this pull request May 8, 2020
Closed
@stuartmorgan-g stuartmorgan-g mentioned this pull request May 13, 2020
Merged
@stuartmorgan-g stuartmorgan-g mentioned this pull request May 19, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@franciscojma86 @googlebot @fluttergithubbot @yjbanov @ferhatb @stuartmorgan-g @gspencergoog