Skip to content

[flutter_tools] Migrate to package:vm_service 4: trigonometric boogaloo #54132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 11 commits into from
Apr 8, 2020
Merged

[flutter_tools] Migrate to package:vm_service 4: trigonometric boogaloo #54132

jonahwilliams merged 11 commits into from
Apr 8, 2020

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Apr 6, 2020 •
edited
Loading

Description

Reland VM service migration. Fix unknown double-complete which broke flutter_test_performance.

test stdout (TestStep.testRunning): 00:01 +1 -1: loading /home/flutter/.cocoon/flutter/dev/automated_tests/flutter_test/trivial_widget_test.dart [E]                                                                                       
2020-04-06T10:30:42.377762: test stdout (TestStep.testRunning):   Bad state: Future already completed
2020-04-06T10:30:42.411011: test stdout (TestStep.testRunning):   dart:async/future_impl.dart 42:31                              _AsyncCompleter.complete
test stdout (TestStep.testRunning):   package:flutter_tools/src/vmservice.dart 363:29                VMService._connect.<fn>
2020-04-06T10:30:42.411101: test stdout (TestStep.testRunning):   package:stack_trace/src/stack_zone_specification.dart 209:15   StackZoneSpecification._run
test stdout (TestStep.testRunning):   package:stack_trace/src/stack_zone_specification.dart 119:48   StackZoneSpecification._registerCallback.<fn>
test stdout (TestStep.testRunning):   dart:async/zone.dart 1180:38

@fluttergithubbot fluttergithubbot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Apr 6, 2020
jonahwilliams
jonahwilliams commented Apr 7, 2020
View reviewed changes
packages/flutter_tools/lib/src/vmservice.dart
channel.add,
log: null,
disposeHandler: () async {
if (!streamClosedCompleter.isCompleted) {
Copy link
Contributor Author

@jonahwilliams jonahwilliams Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing check for is completed. The old VM service might have been OK with being torn down multiple times though, not sure. At any rate I can't repro the test failure anymore

Copy link
Member

@zanderso zanderso Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're trying to tear it down twice, could we also be trying to use it after closing it in some other way?

Copy link
Contributor Author

@jonahwilliams jonahwilliams Apr 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked into it a bit more and I'm not certain - I can't consistently repro the crash. I think the stream logic is just too complicated right now, and should be a bit simpler once I no longer need to duplicate events

@jonahwilliams jonahwilliams marked this pull request as ready for review April 7, 2020 19:24
@jonahwilliams jonahwilliams requested a review from zanderso April 7, 2020 19:24
zanderso
zanderso approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ question.

packages/flutter_tools/lib/src/vmservice.dart
channel.add,
log: null,
disposeHandler: () async {
if (!streamClosedCompleter.isCompleted) {
Copy link
Member

@zanderso zanderso Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're trying to tear it down twice, could we also be trying to use it after closing it in some other way?

@jonahwilliams jonahwilliams merged commit 4851888 into flutter:master Apr 8, 2020
@jonahwilliams jonahwilliams deleted the migrate_to_vm_service_boogaloo branch April 8, 2020 19:33
@kf6gpe kf6gpe mentioned this pull request Apr 9, 2020
Closed
@devoncarew devoncarew mentioned this pull request Apr 14, 2020
Closed
This was referenced Sep 22, 2020
Closed
Closed
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso zanderso approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonahwilliams @zanderso @googlebot @fluttergithubbot